chore: use helper for exhaustiveness checks #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasciccola
approved these changes
Mar 11, 2024
tomasciccola
added a commit
that referenced
this pull request
Mar 11, 2024
* differenciate two icon types (png and svg), fix tests * move size and blobVersionId outside of variants, to avoid repetition * addressing review * remove empty check in decode-conversions * remove unused imports and commented function in encode-conversions * run prettier on schema/icon/v1.json * throw error if invalid mimeType (but can't print the mimetype itself because it won't please ts) * chore: use helper for exhaustiveness checks (#175) --------- Co-authored-by: Tomás Ciccola <tciccola@digital-democracy.com> Co-authored-by: Evan Hahn <me@evanhahn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged into #174.