Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: two icon types (svg and png) #174

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Feat: two icon types (svg and png) #174

merged 6 commits into from
Mar 11, 2024

Conversation

tomasciccola
Copy link
Contributor

This should close #160

EvanHahn
EvanHahn requested changes Mar 4, 2024
View reviewed changes
proto/icon/v1.proto Outdated Show resolved Hide resolved
proto/icon/v1.proto Outdated Show resolved Hide resolved
proto/icon/v1.proto Outdated Show resolved Hide resolved
@tomasciccola tomasciccola requested a review from EvanHahn March 6, 2024 16:47
EvanHahn
EvanHahn requested changes Mar 7, 2024
View reviewed changes
src/lib/encode-conversions.ts Outdated Show resolved Hide resolved
proto/icon/v1.proto Show resolved Hide resolved
schema/icon/v1.json Outdated Show resolved Hide resolved
src/lib/decode-conversions.ts Outdated Show resolved Hide resolved
src/lib/decode-conversions.ts Show resolved Hide resolved
src/lib/encode-conversions.ts Outdated Show resolved Hide resolved
src/lib/encode-conversions.ts Outdated Show resolved Hide resolved
Tomás Ciccola added 3 commits March 7, 2024 09:24
addressing review
c756778 
* remove empty check in decode-conversions
* remove unused imports and commented function in encode-conversions
* run prettier on schema/icon/v1.json
throw error if invalid mimeType (but can't print the mimetype itself
3282e2d 
because it won't please ts)
Merge branch 'main' of github.com:digidem/mapeo-schema into feat/twoI…
cd646f9 
…conTypes
@tomasciccola tomasciccola requested a review from EvanHahn March 7, 2024 15:36
@EvanHahn EvanHahn mentioned this pull request Mar 11, 2024
Merged
@tomasciccola tomasciccola merged commit 8da26ed into main Mar 11, 2024
6 checks passed
@tomasciccola tomasciccola deleted the feat/twoIconTypes branch March 11, 2024 21:18
gmaclennan added a commit that referenced this pull request Apr 8, 2024
@gmaclennan
Merge branch 'main' into chore/rename-role
3e6dfed 
* main:
  chore: replace Tape with Node's built-in test runner (#176)
  Feat: two icon types (svg and png) (#174)
This was referenced Apr 9, 2024
Closed
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 16, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 15, 2024
Merged
This was referenced Aug 1, 2024
Merged
Merged
Merged
This was referenced Aug 24, 2024
Merged
Merged
Merged
Merged
This was referenced Sep 2, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Sep 3, 2024
Merged
This was referenced Sep 16, 2024
Merged
Closed
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHahn EvanHahn EvanHahn approved these changes

@gmaclennan gmaclennan Awaiting requested review from gmaclennan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[icon] should a variant's pixelDensity only be defined for applicable mime types?
2 participants
@tomasciccola @EvanHahn