feat: Add RPC sendDeviceInfo() + device-info event #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@gmaclennan is this ready for review? |
|
No tests yet, but otherwise done. |
achou11
reviewed
Sep 19, 2023
|
@gmaclennan added a couple of tests in 8fdb7ea if you want to take a second to look through those before merging |
|
Looks good to me. I can't approve since I own the PR, but ok to merge. |
achou11
approved these changes
Oct 3, 2023
tomasciccola
pushed a commit
that referenced
this pull request
Oct 3, 2023
Co-authored-by: Andrew Chou <andrewchou@fastmail.com>
This was referenced Nov 16, 2023
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #245
TODO: tests