Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send device name over RPC channel #245

Closed
1 of 2 tasks
gmaclennan opened this issue Sep 2, 2023 · 1 comment · Fixed by #270
Closed
1 of 2 tasks

Send device name over RPC channel #245

gmaclennan opened this issue Sep 2, 2023 · 1 comment · Fixed by #270
Assignees
@gmaclennan

Comments

@gmaclennan
Copy link
Member

gmaclennan commented Sep 2, 2023 •
edited by achou11
Loading

Description

We don't want to expose device names in multicast messages for MDNS discovery, so instead we will pass the name as a message over the RPC channel on first connect, so that devices could choose not to send their name to untrusted devices.

Tasks

  • Add method for sending and receiving deviceInfo over the RPC channel
  • Send a device's info on first connect
@gmaclennan gmaclennan mentioned this issue Sep 2, 2023
Merged
@gmaclennan gmaclennan linked a pull request Sep 14, 2023 that will close this issue
feat: Add RPC sendDeviceInfo() + device-info event #270
Merged
@gmaclennan gmaclennan mentioned this issue Sep 14, 2023
Merged
@achou11 achou11 mentioned this issue Sep 28, 2023
Closed
@achou11 achou11 reopened this Oct 4, 2023
@achou11 achou11 mentioned this issue Oct 4, 2023
Closed
@achou11
Copy link
Member

achou11 commented Oct 4, 2023

Closing and will create a new issue for the second task, which is blocked on some mdns-related work

@achou11 achou11 closed this as completed Oct 4, 2023
@achou11 achou11 removed their assignment Oct 4, 2023
@achou11 achou11 mentioned this issue Oct 4, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmaclennan gmaclennan

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gmaclennan @achou11