Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun cookiecutter with codespell edits #55

Merged
merged 13 commits into from
Nov 6, 2024
Merged

Conversation

cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Nov 6, 2024

closes #50 , #53 , and #54. This PR contains edits made by the cookiecutter as well as spellcheck edits recommended by codespell.

Copy link

codecov bot commented Nov 6, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@bobleesj
Copy link
Contributor

bobleesj commented Nov 6, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Great

@bobleesj
Copy link
Contributor

bobleesj commented Nov 6, 2024

@cadenmyers13 Seems like the codecov is failing now after the recent commit

Since it has been tested and the codecov comment asks to merge to have the report, I think we can merge this

@bobleesj
Copy link
Contributor

bobleesj commented Nov 6, 2024

@cadenmyers13 then could you please check after whether the codecov in a new PR?

@sbillinge
Copy link
Contributor

this is failing. I may have to set up codecov. I will do when i can....

@bobleesj
Copy link
Contributor

bobleesj commented Nov 6, 2024

Screenshot 2024-11-06 at 6 13 21 PM

@sbillinge it was actually passing - until a new commit was made for the quick fix above. b9cab13

I think codecov has been integrated

Screenshot 2024-11-06 at 6 14 26 PM

Could we try merging this?

@sbillinge sbillinge merged commit 4c40b78 into diffpy:main Nov 6, 2024
2 of 3 checks passed
@cadenmyers13 cadenmyers13 deleted the cookie branch November 7, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proofread docs and source code
3 participants