Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofread docs and source code #50

Closed
bobleesj opened this issue Oct 30, 2024 · 4 comments · Fixed by #55
Closed

Proofread docs and source code #50

bobleesj opened this issue Oct 30, 2024 · 4 comments · Fixed by #55

Comments

@bobleesj
Copy link
Contributor

@Fil158 has volunteered to identify any typos in the documentations/code. Could you please close this issue after you've created a PR to fix typos identified in this package?

@Fil158
Copy link

Fil158 commented Oct 30, 2024

I modified, opened the PR and made the news. There is a "pre-commit.ci - pr — error during mergeable check" and I run pytest and the result is "1 failed, 17 passed, 10 warnings".

@Fil158
Copy link

Fil158 commented Oct 30, 2024

Now I did
pre-commit autoupdate and then pre-commit run --all-files and I solved the failed test

@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 1, 2024

@Fil158 this needs to be closed so that @cadenmyers13 can release the package. I believe you created the PR. Could you please share an update?

@Fil158
Copy link

Fil158 commented Nov 6, 2024

I'm in touch with Caden to fix warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants