RDF Formatter Contribution #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: Expecting a dependency update for turtle-formatter soon-ish (PR already submitted). If it is allowed by your review process, I'd bump that dependency as it becomes available. EDIT: that's done. |
|
Looks great! Needs an entry in the |
Comparing graph nodes using their `equals()` method is used under the hood by the isomorphicity check and therefore has to be used in the diff calcluation as well (otherwise the latter might not find any differences). Special handling of blank nodes has been omitted as it is hard to find which ones are different and which ones are not, so we just print them all for now.
|
I think it's done now. |
|
@nedtwigg ... what do I do? rebase and force-push ? |
|
Nope, I just fixed the merge conflict, if CI passes this should be good to go. |
|
Run |
|
Done. |
|
Limited the tests to JDK >= 17 to deal with the tests failing for java 11. Hope that's it now. |
|
@nedtwigg could you please approve the workflow runs? Thanks! |
Open
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a formatter for RDF
In its current form, only the TTL format can be formatted using turtle-formatter. All other formats could be handled with Jena, but are currently not implemented.
The PR contains code for a maven plugin, but not a gradle/sbt plugin.
Options are:
The PR includes smoke tests that use input/output folders containing files with identical names, for which a utility method was added to the ResourceHarness.