Draft: Introduce a build process based on maven #975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkleedorfer
requested review from
steveraysteveray,
ralphtq and
jhodgesatmb
as code owners
|
Should the build process maybe be in R2?
|
|
what's R2? |
|
It is the QUDT development branch. It is where we keep ‘code’ related things, for example.
|
I don't think so. Having the build in the public repo allows every contributor to build the whole thing and execute all the checks if they want. Moreover if the build is in this repo, we can trigger it upon PR in a github action and the checks are executed automatically. Less work for everyone. Plus, contributors can improve the build process, too |
|
I have had projects in R2 that were later moved to public
|
- spotless for RDF formatting - Use released shacl-maven-plugin - infer applicableUnits using SHACL-AF rules - enforce SHACL shapes
- format shacl file
fkleedorfer
force-pushed
the
959/maven
branch
from
a8b5f3f
to
8e88285
Compare
|
You wanted to check it in so I offered an option to get it into the got tracking. It can be moved into the public repo later when it goes operational. We have done this before. I am not dictating anything; just offering an idea.Jack Hodges, Ph.D.Arbor StudiosOn Sep 24, 2024, at 11:58 AM, Jack Hodges ***@***.***> wrote:I have had projects in R2 that were later moved to public.Jack Hodges, Ph.D.Arbor StudiosOn Sep 24, 2024, at 9:55 AM, Florian Kleedorfer ***@***.***> wrote:
Should the build process maybe be in R2?
I don't think so. Having the build in the public repo allows every contributor to build the whole thing and execute all the checks if they want. Moreover if the build is in this repo, we can trigger it upon PR in a github action and the checks are executed automatically. Less work for everyone. Plus, contributors can improve the build process, too
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
Sorry, responded to the earlier message as that was what was shown when I opened the mail. That said, I still believe what I said is the best approach.Jack Hodges, Ph.D.Arbor StudiosOn Oct 27, 2024, at 8:38 PM, Jack Hodges ***@***.***> wrote:You wanted to check it in so I offered an option to get it into the got tracking. It can be moved into the public repo later when it goes operational. We have done this before. I am not dictating anything; just offering an idea.Jack Hodges, Ph.D.Arbor StudiosOn Sep 24, 2024, at 11:58 AM, Jack Hodges ***@***.***> wrote:I have had projects in R2 that were later moved to public.Jack Hodges, Ph.D.Arbor StudiosOn Sep 24, 2024, at 9:55 AM, Florian Kleedorfer ***@***.***> wrote:
Should the build process maybe be in R2?
I don't think so. Having the build in the public repo allows every contributor to build the whole thing and execute all the checks if they want. Moreover if the build is in this repo, we can trigger it upon PR in a github action and the checks are executed automatically. Less work for everyone. Plus, contributors can improve the build process, too
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
Closing in favor of the same PR off a branch in the qudt-public-repo repository instead of a fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a - for now prototypical - implementation of a build process based on maven.
Structure
Operations
Addresses #959