-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selfie docs #24
Selfie docs #24
Conversation
This should be ready to merge now. One remaining issue that needs tweaking is the mascot scroll speed on desktop sizes is too fast because the positioning changed from fixed to absolute at that breakpoint. I'll make a separate PR for that later, but otherwise the above-the-fold styling should be in good shape. Let me know if you find additional things that need adjustments too. |
Feel free to merge at any time, we can punt any of these items into the future. |
I'm not seeing a breakpoint issue. There are 4 screen sizes, mobile (<600), wide-mobile (<800), tablet (<1159), and desktop. There's an additional "breakpoint" at 1300 that will likely go away that's only used for the mascot and is related to the issue in my comment above, but it doesn't affect the layout/sizing of any of the other components. Can you give more detail on the issue you're seeing? Tbh, some of the framer styles are a bit janky with floating point sizes and positioning, which I tried to clean up. I tweaked the button sizes and positioning to be closer to framer, but it'll be pretty nasty to make it exact. Let me know if you want it to look different though and we can make it happen. |
Merging this to capture the value. Tracking remaining todos here in issues so they can be done in the future. #27 is opened for the mascot issue. |
No description provided.