Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mascot position/animation #27

Closed
WebsByTodd opened this issue Oct 2, 2023 · 0 comments
Closed

Improve mascot position/animation #27

WebsByTodd opened this issue Oct 2, 2023 · 0 comments
Labels
docs Improvements or additions to documentation

Comments

@WebsByTodd
Copy link
Collaborator

Desired behavior:

  • Mascot is behaving perfectly today at screen widths smaller than 1300px. Keep this behavior.
  • At 1300px and above, the mascot should remain fixed relative to the 1300px wide content column. It should not be fixed to the left edge of the viewport.
  • At 1300px and above, the mascot scroll animation should be pretty much identical to the scroll animation at 1299px.

Current behavior:

To get the mascot fixed relative to the content column, I changed its position from fixed to absolute at the 1300px breakpoint. However, this breaks the scroll animation. I tried messing with the calculations in the animation config with absolute positioning but I couldn't come close to getting it to work.

I think the solution is to keep the mascot with fixed positioning to restore scroll animation behavior and to use translateX and left in some combination to keep it inside that 1300px content column.

@WebsByTodd WebsByTodd added the docs Improvements or additions to documentation label Oct 2, 2023
@WebsByTodd WebsByTodd mentioned this issue Oct 2, 2023
@nedtwigg nedtwigg closed this as completed Jan 9, 2024
nedtwigg added a commit that referenced this issue Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants