Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stairs rendering in Caves and Hell #7439

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Commits on Sep 27, 2024

  1. Fix stairs rendering in Caves and Hell

    Stairs can have the same `TileProperties` as floors but do not
    always follor the same graphics layout as floors, so we shouldn't
    apply optimizations to them.
    
    The only floors affected seem to be:
    
    1. Caves: tile 48 sub-tile 171 frame 461 (TileProperties: None)
    2. Hell: tile 46 sub-tile 141 frame 386 (TileProperties: BlocksMissile)
    
    Note that the few broken in pixels in caves are actually incorrectly
    attributed to the non-Solid tile, really they should be part of the
    solid tile 49.
    
    As there doesn't seem to be a quick and easy way to check if a frame
    is part of Stairs, we add a check for BlocksMissile tile property
    instead.
    
    This fixes Hell but isn't enough to fix Caves.
    To fix Caves, we then add a `BlocksMissile` flag to the broken sub-tile.
    glebm committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    231005e View commit details
    Browse the repository at this point in the history