Fix stairs rendering in Caves and Hell #7439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stairs can have the same `TileProperties` as floors but do not always follor the same graphics layout as floors, so we shouldn't apply optimizations to them. The only floors affected seem to be: 1. Caves: tile 48 sub-tile 171 frame 461 (TileProperties: None) 2. Hell: tile 46 sub-tile 141 frame 386 (TileProperties: BlocksMissile) Note that the few broken in pixels in caves are actually incorrectly attributed to the non-Solid tile, really they should be part of the solid tile 49. As there doesn't seem to be a quick and easy way to check if a frame is part of Stairs, we add a check for BlocksMissile tile property instead. This fixes Hell but isn't enough to fix Caves. To fix Caves, we then add a `BlocksMissile` flag to the broken sub-tile.
AJenbo
approved these changes
Sep 27, 2024
|
|
Caves stairs are always up against a wall, right? Does it matter? |
|
If it isn't we need to apply the property to it to also fix that case. I'm just wondering if there was an oversight and the PR is only fixing 2/3 cases. |
|
Confirmed that all 3 cases are indeed fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stairs can have the same
TilePropertiesas floors but do not always follor the same graphics layout as floors, so we shouldn't apply optimizations to them.The only stairs that are affected seem to be:
Note that the few broken in pixels in caves are actually incorrectly attributed to the non-Solid tile, really they should be part of the solid tile 49.
As there doesn't seem to be a quick and easy way to check if a frame is part of Stairs, we add a check for BlocksMissile tile property instead.
This fixes Hell but isn't enough to fix Caves.
To fix Caves, we then add a
BlocksMissileflag to the broken sub-tile.Fixes #7420
Broken hell tile:
Broken caves tile:
