Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Book requirements not updating from Objects (Part 2) #6322

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

kphoenix137
Copy link
Collaborator

Builds upon #6316 where I mistakenly forgot to refresh item requirements. The other PR updates the player's Spell Level immediately which is necessary for updating magic requirements, but then we need to iterate all inventory and stash items to update requirements.

@kphoenix137 kphoenix137 changed the title Fix Book requirements not updating from Objects #2 Fix Book requirements not updating from Objects (Part 2) Jul 8, 2023
@qndel
Copy link
Member

qndel commented Jul 8, 2023

I think it could be worth it to move it to a separate function

@kphoenix137
Copy link
Collaborator Author

I think it could be worth it to move it to a separate function

I'll do that

Copy link
Member

@AJenbo AJenbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a follow up to make a helper to avoid the duplicate code

@AJenbo AJenbo merged commit 9dcf264 into diasurgical:master Jul 8, 2023
18 checks passed
@kphoenix137 kphoenix137 deleted the fix-book-mag-req-from-obj-2 branch July 9, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants