Fix Book requirements not updating from Objects #6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mistakenly omitted changing spell level using a variable instead of incrementing/decrementing directly and forgot the cache update. Will fix |
AJenbo
approved these changes
Jul 6, 2023
qndel
reviewed
Jul 7, 2023
| @@ -2548,15 +2548,17 @@ void OperateShrineEnchanted(Player &player) | |||
| spell = 1; | |||
| for (uint8_t j = static_cast<uint8_t>(SpellID::Firebolt); j < maxSpells; j++) { | |||
| if ((player._pMemSpells & spell) != 0 && player._pSplLvl[j] < MaxSpellLevel && j != spellToReduce) { | |||
| player._pSplLvl[j]++; | |||
| NetSendCmdParam2(true, CMD_CHANGE_SPELL_LEVEL, j, static_cast<uint8_t>(player._pSplLvl[j] + 1)); | |||
| uint8_t newSpellLevel = static_cast<uint8_t>(player._pSplLvl[j] + 1); | |||
There was a problem hiding this comment.
why do you static_cast<uint8_t> if there's no casting in the function above (with guardian)? it's inconsistent :(
There was a problem hiding this comment.
I left the previous static_cast intact. wasn't really sure why it's there to begin with but just wanted to make as little changes as possible to fix the issue with magic requirements. I'm going to open another PR since this PR isn't complete (forgot to refresh item cache). I will make that change in that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6315
Applies the same fix as #6312 but for Shrines and the Chamber of Bone Tome.