docs: Update readme for PR validation requirements. #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarts
approved these changes
Jan 9, 2025
smohan-dw
added a commit
that referenced
this pull request
Jan 26, 2025
* Registries: Remove registry-id as a argument for create (#559) Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * pallet-asset: Added new test-case for DistributionLimitExceeded. (#522) This issue has been structured similarly to the `asset_create_should_succeed` test. This test will ensure that an asset can be issued successfully and will include coverage for reaching and exceeding the `MaxAssetDistribution` limit. - Test Initialization: The test sets up a space, approves it, and creates an asset similarly to the `asset_create_should_succeed` test. - Asset Issuance: The loop issues the asset up to the `MaxAssetDistribution` limit (set to 25 for testing). Each iteration simulates issuing the asset to a different recipient. - Error Handling: After the limit is reached, the test tries to issue the asset to one more recipient, which should trigger the `DistributionLimitExceeded` error. This ensures that the pallet's logic correctly handles and enforces the distribution limit. This implementation checks that the asset issuance process is valid up to the `MaxAssetDistribution` limit and correctly throws an error when the `limit` is exceeded. * Namespace: Add pallet to have namespace feature (#560) Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * namespace: Remove approval requirement for usage (#563) Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * docs: Update readme for PR validation requirements. (#540) * network-score : Add Test Cases for SpaceMismatch error Fixes: #304 * network-score: Add Test Cases for SpaceMismatch Error in pallet-network-score Signed-off-by: Aman Raj <113578582+huamanraj@users.noreply.github.com> * namespace: Add digest and blob for namespace create Fixes: #564 Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * namespace: Identifier updates (#565) Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * namespace: Integrate with Registries framework Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * registries: Integration testing with Namespace Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * registries: Benchmarking updates for Namespace Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * entries: Integration testing with updated Registries & Namespace Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * Update to use new identifiers Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * namespace, registries: Update lookup table on create (#569) Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * Update the CORD version to 0.9.5 (#570) Signed-off-by: Shreevatsa N <vatsa@dhiway.com> * Registries: Add tests for AuthorizationNotFound (#566) * registries: add tests for AuthorizationNotFound --------- Co-authored-by: Mudit Sarda <muditsarda@Mudits-MacBook-Pro.local> * Fixes: #310 Add test cases for SchemaNotFound error (#551) Signed-off-by: Vaibhav <sahusv4527@gmail.com> * fix upstream merge conflicts --------- Signed-off-by: Shreevatsa N <vatsa@dhiway.com> Signed-off-by: Aman Raj <113578582+huamanraj@users.noreply.github.com> Signed-off-by: Vaibhav <sahusv4527@gmail.com> Co-authored-by: Shree Vatsa N <vatsa@dhiway.com> Co-authored-by: RITANKAR SAHA <ritankar.saha786@gmail.com> Co-authored-by: Aman Raj <113578582+huamanraj@users.noreply.github.com> Co-authored-by: muditDhiway <mudit.sarda@dhiway.com> Co-authored-by: Mudit Sarda <muditsarda@Mudits-MacBook-Pro.local> Co-authored-by: VAIBHAV SAHU <154520239+Vaibhavsahu2810@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.