Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C4GT] Schema: Add tests for SchemaNotFound #310

Closed
3 tasks
vatsa287 opened this issue Feb 6, 2024 · 6 comments · Fixed by #551 · May be fixed by #400
Closed
3 tasks

[C4GT] Schema: Add tests for SchemaNotFound #310

vatsa287 opened this issue Feb 6, 2024 · 6 comments · Fixed by #551 · May be fixed by #400
Assignees
Labels

Comments

@vatsa287
Copy link
Member

vatsa287 commented Feb 6, 2024

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-schema after adding it in the code.

Goals

  • Add tests for SchemaNotFound for pallet/schema

Expected Outcome

  • Test should assert for SchemaNotFound being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: check method check_duplicate_schema_creation which validates error code SchemaAlreadyAnchored

Mockups / Wireframes

NA


Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts

Complexity

[Medium]

Category

[Test]

Sub Category

[Beginner friendly]

@sahil-1729
Copy link

sahil-1729 commented Mar 17, 2024

@vatsa287 @amarts I am interested in working on this issue

@Anushreebasics
Copy link

@vatsa287 I am interested to work on this, plz guide me

@Aloneking789
Copy link

I am intested in this .I have also made a Pull request .

@avi8115
Copy link

avi8115 commented Aug 8, 2024

Dear @vatsa287 sir I am interested and want to fix this issue.

@vatsa287 vatsa287 assigned avi8115 and unassigned sahil-1729 Aug 9, 2024
@VedantKhairnar
Copy link

Hello @avi8115,
Please let us know if you need any assistance.
Thanks.

@Vaibhavsahu2810
Copy link
Contributor

Vaibhavsahu2810 commented Dec 21, 2024

Hello @vatsa287, can i work on this issue

Vaibhavsahu2810 added a commit to Vaibhavsahu2810/cord that referenced this issue Dec 28, 2024
Signed-off-by: Vaibhav <sahusv4527@gmail.com>
smohan-dw added a commit that referenced this issue Jan 26, 2025
* Registries: Remove registry-id as a argument for create (#559)

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* pallet-asset: Added new test-case for DistributionLimitExceeded. (#522)

This issue has been structured  similarly to the `asset_create_should_succeed` test.
This test will ensure that an asset can be issued successfully and will include coverage for reaching and exceeding the `MaxAssetDistribution` limit.

- Test Initialization:
The test sets up a space, approves it, and creates an asset similarly to the `asset_create_should_succeed` test.
- Asset Issuance:
The loop issues the asset up to the `MaxAssetDistribution` limit (set to 25 for testing). Each iteration simulates issuing the asset to a different recipient.
- Error Handling:
After the limit is reached, the test tries to issue the asset to one more recipient, which should trigger the `DistributionLimitExceeded` error. This ensures that the pallet's logic correctly handles and enforces the distribution limit.

This implementation checks that the asset issuance process is valid up to the `MaxAssetDistribution`  limit and correctly throws an error when the `limit` is exceeded.

* Namespace: Add pallet to have namespace feature (#560)


Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* namespace: Remove approval requirement for usage (#563)

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* docs: Update readme for PR validation requirements. (#540)

* network-score :  Add Test Cases for SpaceMismatch error

Fixes: #304 
* network-score: Add Test Cases for SpaceMismatch Error in pallet-network-score

Signed-off-by: Aman Raj <113578582+huamanraj@users.noreply.github.com>

* namespace: Add digest and blob for namespace create 

Fixes: #564

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* namespace: Identifier updates (#565)

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* namespace: Integrate with Registries framework

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* registries: Integration testing with Namespace

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* registries: Benchmarking updates for Namespace

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* entries: Integration testing with updated Registries & Namespace

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* Update to use new identifiers

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* namespace, registries: Update lookup table on create (#569)

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* Update the CORD version to 0.9.5 (#570)

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>

* Registries: Add tests for AuthorizationNotFound (#566)

* registries: add tests for AuthorizationNotFound
---------

Co-authored-by: Mudit Sarda <muditsarda@Mudits-MacBook-Pro.local>

* Fixes: #310 Add test cases for SchemaNotFound error (#551)

Signed-off-by: Vaibhav <sahusv4527@gmail.com>

* fix upstream merge conflicts

---------

Signed-off-by: Shreevatsa N <vatsa@dhiway.com>
Signed-off-by: Aman Raj <113578582+huamanraj@users.noreply.github.com>
Signed-off-by: Vaibhav <sahusv4527@gmail.com>
Co-authored-by: Shree Vatsa N <vatsa@dhiway.com>
Co-authored-by: RITANKAR SAHA <ritankar.saha786@gmail.com>
Co-authored-by: Aman Raj <113578582+huamanraj@users.noreply.github.com>
Co-authored-by: muditDhiway <mudit.sarda@dhiway.com>
Co-authored-by: Mudit Sarda <muditsarda@Mudits-MacBook-Pro.local>
Co-authored-by: VAIBHAV SAHU <154520239+Vaibhavsahu2810@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants