-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: manage Notifier storage usage [DHIS2-17998] (2.40) #19816
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: manage Notifier storage usage [DHIS2-17998] (#19738) * feat: gist for overview lists, limit setting [DHIS2-17998] * refactor: NotifierStore implemented * feat: clear and cap API and endpoints * feat: cap for redis store * fix: cap and clean consistency, log level filter for scheduling only * chore: API cleanup, javadoc, some test fixes * fix: notifier tests * fix: hide transient empty in-memory stores in the API * fix: update test assert with new message * fix: remove notifier stubbing from mock test * fix: e2e test assert for updated message * fix: mock test setup, dependencies * fix: add jackson core back in * fix: exclude jackson core from dependency check * fix: sonar issues * test: notifier API tests for in-memory and redis * fix: sonar warnings * chore: fix typo * chore: prevent null message logging + log cleanup [DHIS2-17998] (#19800) * fix: maven dependencies + mock tests * fix: add Long conversion * fix: e2e test message expectations after change in wording
We decided to revert the PR to before this commit 8803cb7 and use jackson as a Java11 replacement for json-tree within the |
751be22
to
8edf135
Compare
|
netroms
approved these changes
Feb 11, 2025
david-mackessy
approved these changes
Feb 12, 2025
enricocolasante
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked from #19807
with a fair number of further conflicts to resolve manually.
record
and.toList()
mostly)