Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage Notifier storage usage [DHIS2-17998] (2.40) #19816

Merged
merged 13 commits into from
Feb 12, 2025
Merged

Conversation

jbee
Copy link
Contributor

@jbee jbee commented Jan 30, 2025

cherry-picked from #19807

with a fair number of further conflicts to resolve manually.

  • go back to Java 11 (undoing use of record and .toList() mostly)
  • use jackson for any from/to JSON

* feat: manage Notifier storage usage [DHIS2-17998] (#19738)

* feat: gist for overview lists, limit setting [DHIS2-17998]

* refactor: NotifierStore implemented

* feat: clear and cap API and endpoints

* feat: cap for redis store

* fix: cap and clean consistency, log level filter for scheduling only

* chore: API cleanup, javadoc, some test fixes

* fix: notifier tests

* fix: hide transient empty in-memory stores in the API

* fix: update test assert with new message

* fix: remove notifier stubbing from mock test

* fix: e2e test assert for updated message

* fix: mock test setup, dependencies

* fix: add jackson core back in

* fix: exclude jackson core from dependency check

* fix: sonar issues

* test: notifier API tests for in-memory and redis

* fix: sonar warnings

* chore: fix typo

* chore: prevent null message logging + log cleanup [DHIS2-17998] (#19800)

* fix: maven dependencies + mock tests

* fix: add Long conversion

* fix: e2e test message expectations after change in wording
@jbee jbee self-assigned this Jan 30, 2025
@jbee jbee changed the title feat: manage Notifier storage usage [DHIS2-17998] (2.41) feat: manage Notifier storage usage [DHIS2-17998] (2.40) Jan 30, 2025
@jbee
Copy link
Contributor Author

jbee commented Feb 5, 2025

We decided to revert the PR to before this commit 8803cb7 and use jackson as a Java11 replacement for json-tree within the RedisNotifierStore implementation.

@jbee jbee marked this pull request as ready for review February 12, 2025 07:51
@jbee jbee requested a review from a team February 12, 2025 07:52
@jbee jbee merged commit d263520 into 2.40 Feb 12, 2025
15 checks passed
@jbee jbee deleted the DHIS2-17998_2.40 branch February 12, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants