chore: prevent null message logging [DHIS2-17998] #19800
Merged
+12
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vietnguyen
approved these changes
Jan 29, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ort/dhis-support-system/src/main/java/org/hisp/dhis/system/notification/DefaultNotifier.java
Dismissed
Show dismissed
Hide dismissed
david-mackessy
approved these changes
Jan 29, 2025
jbee
added a commit
that referenced
this pull request
Jan 29, 2025
jbee
added a commit
that referenced
this pull request
Jan 30, 2025
* feat: manage Notifier storage usage [DHIS2-17998] (#19738) * feat: gist for overview lists, limit setting [DHIS2-17998] * refactor: NotifierStore implemented * feat: clear and cap API and endpoints * feat: cap for redis store * fix: cap and clean consistency, log level filter for scheduling only * chore: API cleanup, javadoc, some test fixes * fix: notifier tests * fix: hide transient empty in-memory stores in the API * fix: update test assert with new message * fix: remove notifier stubbing from mock test * fix: e2e test assert for updated message * fix: mock test setup, dependencies * fix: add jackson core back in * fix: exclude jackson core from dependency check * fix: sonar issues * test: notifier API tests for in-memory and redis * fix: sonar warnings * chore: fix typo * chore: prevent null message logging + log cleanup [DHIS2-17998] (#19800) * fix: maven dependencies + mock tests * fix: add Long conversion * fix: e2e test message expectations after change in wording
jbee
added a commit
that referenced
this pull request
Jan 30, 2025
* feat: manage Notifier storage usage [DHIS2-17998] (#19738) * feat: gist for overview lists, limit setting [DHIS2-17998] * refactor: NotifierStore implemented * feat: clear and cap API and endpoints * feat: cap for redis store * fix: cap and clean consistency, log level filter for scheduling only * chore: API cleanup, javadoc, some test fixes * fix: notifier tests * fix: hide transient empty in-memory stores in the API * fix: update test assert with new message * fix: remove notifier stubbing from mock test * fix: e2e test assert for updated message * fix: mock test setup, dependencies * fix: add jackson core back in * fix: exclude jackson core from dependency check * fix: sonar issues * test: notifier API tests for in-memory and redis * fix: sonar warnings * chore: fix typo * chore: prevent null message logging + log cleanup [DHIS2-17998] (#19800) * fix: maven dependencies + mock tests * fix: add Long conversion * fix: e2e test message expectations after change in wording
jbee
added a commit
that referenced
this pull request
Feb 12, 2025
* feat: manage Notifier storage usage [DHIS2-17998] (2.41) (#19807) * feat: manage Notifier storage usage [DHIS2-17998] (#19738) * feat: gist for overview lists, limit setting [DHIS2-17998] * refactor: NotifierStore implemented * feat: clear and cap API and endpoints * feat: cap for redis store * fix: cap and clean consistency, log level filter for scheduling only * chore: API cleanup, javadoc, some test fixes * fix: notifier tests * fix: hide transient empty in-memory stores in the API * fix: update test assert with new message * fix: remove notifier stubbing from mock test * fix: e2e test assert for updated message * fix: mock test setup, dependencies * fix: add jackson core back in * fix: exclude jackson core from dependency check * fix: sonar issues * test: notifier API tests for in-memory and redis * fix: sonar warnings * chore: fix typo * chore: prevent null message logging + log cleanup [DHIS2-17998] (#19800) * fix: maven dependencies + mock tests * fix: add Long conversion * fix: e2e test message expectations after change in wording * fix: remove args parameter (that was introduced in 2.41) * fix: back to Java 11 * fix: revert changes to data value import * fix: more back to Java11 * fix: notifier mock tests * fix: test scope * fix: use jackson to convert between JSON and Notification in Redis store * fix: tracker import report usage, mocking * fix: tracker import report from JSON * fix: use jackson for notifier summary * fix: use jackson for notification data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some more manual testing of the notifier changes in #19738 I found that log messages will message
nullwould occur. This prevents it and cleans up the code a bit.