fix: fetch visualization always when caching (DHIS2-17509) v38 #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous fix for an item flashing issue caused the offline cache to lack the request for the visualizations. The fix looks at the recording state and triggers a fetch that can be recorded. (cherry picked from commit c1201fa)
|
🚀 Deployed on https://pr-2988--dhis2-dashboard.netlify.app |
jenniferarnesen
approved these changes
Jun 4, 2024
Passing run #4867 ↗︎
Details:
Review all test suite changes for PR #2988 ↗︎ |
|||||||||||||||
edoardo
changed the title
janhenrikoverland
pushed a commit
that referenced
this pull request
Jun 5, 2024
A previous fix for an item flashing issue caused the offline cache to lack the request for the visualizations. The fix looks at the recording state and triggers a fetch that can be recorded. (cherry picked from commit c1201fa)
janhenrikoverland
added a commit
that referenced
this pull request
Jun 5, 2024
A previous fix for an item flashing issue caused the offline cache to lack the request for the visualizations. The fix looks at the recording state and triggers a fetch that can be recorded. (cherry picked from commit c1201fa) Co-authored-by: Edoardo Sabadelli <edoardo@dhis2.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-17509
Key features
Description
A previous fix for an item flashing issue caused the offline cache to lack the request for the visualizations.
The fix looks at the recording state and triggers a fetch that can be recorded.
(cherry picked from commit c1201fa)