fix: fetch visualization always when caching (DHIS2-17509) #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2986--dhis2-dashboard.netlify.app |
edoardo
changed the title
jenniferarnesen
approved these changes
Jun 3, 2024
This was referenced Jun 4, 2024
edoardo
force-pushed
the
fix/visualization-offline-cache
branch
from
c1201fa
to
32bcaa1
Compare
A previous fix for an item flashing issue caused the offline cache to lack the request for the visualizations. The fix looks at the recording state and triggers a fetch that can be recorded.
edoardo
force-pushed
the
fix/visualization-offline-cache
branch
from
32bcaa1
to
a480d10
Compare
Merged
dhis2-bot
added a commit
that referenced
this pull request
Jun 17, 2024
## [100.2.3](v100.2.2...v100.2.3) (2024-06-17) ### Bug Fixes * **translations:** sync translations from transifex (dev) ([7f44585](7f44585)) * **translations:** sync translations from transifex (dev) ([1c2d1b2](1c2d1b2)) * **translations:** sync translations from transifex (dev) ([ac3f1c7](ac3f1c7)) * **translations:** sync translations from transifex (dev) ([#3001](#3001)) ([018e07b](018e07b)) * fetch visualization always when caching (DHIS2-17509) ([#2986](#2986)) ([8b3587e](8b3587e))
|
🎉 This PR is included in version 100.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17509
Key features
Description
A previous fix for an item flashing issue caused the offline cache to lack the request for the visualization.
The fix looks at the recording state and triggers a fetch that can be recorded.
The affected version of Dashboard app is v100.2.2.
Screenshots
Before, the cache is missing the request for
visualizations:After the cache has an entry for the
visualizationsrequest: