fix: use interpretations component from Analytics (DHIS2-15441) #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The verify workflow should run on tags, so that a corresponding branch is created in the d2-ci repository Do not run the release step on PRs, but do allow it for pushes yarn cypress install sometimes fails. Turns out it isn't necessary anyway since the cypress-io gh action takes care of installing cypress.
Automatically merged.
Automatically merged.
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
* chore: nightly failing to set up cypress (#2378) The verify workflow should run on tags, so that a corresponding branch is created in the d2-ci repository Do not run the release step on PRs, but do allow it for pushes yarn cypress install sometimes fails. Turns out it isn't necessary anyway since the cypress-io gh action takes care of installing cypress. * fix(translations): sync translations from transifex (dev) Automatically merged. * docs: move docs to app (#2384) * chore(release): cut 100.0.1 [skip release] ## [100.0.1](v100.0.0...v100.0.1) (2023-06-12) ### Bug Fixes * **translations:** sync translations from transifex (dev) ([5b0b3b6](5b0b3b6)) * chore(deps): bump @dhis2/analytics from 25.1.10 to 25.1.15 Bumps [@dhis2/analytics](https://github.com/dhis2/analytics) from 25.1.10 to 25.1.15. - [Release notes](https://github.com/dhis2/analytics/releases) - [Changelog](https://github.com/dhis2/analytics/blob/master/CHANGELOG.md) - [Commits](dhis2/analytics@v25.1.10...v25.1.15) --- updated-dependencies: - dependency-name: "@dhis2/analytics" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org> Co-authored-by: @dhis2-bot <apps@dhis2.org> Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Automatically merged.
Also increase the EXTENDED_TIMEOUT
* chore: nightly failing to set up cypress (#2378) The verify workflow should run on tags, so that a corresponding branch is created in the d2-ci repository Do not run the release step on PRs, but do allow it for pushes yarn cypress install sometimes fails. Turns out it isn't necessary anyway since the cypress-io gh action takes care of installing cypress. * fix(translations): sync translations from transifex (dev) Automatically merged. * docs: move docs to app (#2384) * chore(release): cut 100.0.1 [skip release] ## [100.0.1](v100.0.0...v100.0.1) (2023-06-12) ### Bug Fixes * **translations:** sync translations from transifex (dev) ([5b0b3b6](5b0b3b6)) * chore(deps): bump @dhis2/ui from 8.13.6 to 8.13.11 Bumps [@dhis2/ui](https://github.com/dhis2/ui/tree/HEAD/collections/ui) from 8.13.6 to 8.13.11. - [Release notes](https://github.com/dhis2/ui/releases) - [Changelog](https://github.com/dhis2/ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/dhis2/ui/commits/v8.13.11/collections/ui) --- updated-dependencies: - dependency-name: "@dhis2/ui" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org> Co-authored-by: @dhis2-bot <apps@dhis2.org> Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This is temporary during summer 2023 when there is very little frontend or backend activity
…his2/dashboard-app into feat/replace-interpretations-component
jenniferarnesen
force-pushed
the
dev
branch
from
e63aff9
to
35877e1
Compare
jenniferarnesen
changed the title
|
🚀 Deployed on https://pr-2430--dhis2-dashboard.netlify.app |
jenniferarnesen
added a commit
that referenced
this pull request
Mar 19, 2024
dhis2-bot
added a commit
that referenced
this pull request
Mar 21, 2024
# [100.1.0](v100.0.4...v100.1.0) (2024-03-21) ### Bug Fixes * show tag/tooltip about not applied filters for Outlier table (DHIS2-13858) ([#2937](#2937)) ([dffb754](dffb754)) * show tag/tooltip only when a filter other than ou/pe is used ([#2941](#2941)) ([b6b8850](b6b8850)) * **translations:** sync translations from transifex (dev) ([755c6df](755c6df)) * use interpretations component from Analytics (DHIS2-15441) ([#2430](#2430)) ([0af5c5b](0af5c5b)) * **translations:** sync translations from transifex (dev) ([0de3606](0de3606)) * **translations:** sync translations from transifex (dev) ([b88e87c](b88e87c)) * **translations:** sync translations from transifex (dev) ([#2920](#2920)) ([add7139](add7139)) ### Features * support outlier table plugin (DHIS2-16751) ([#2912](#2912)) ([1af22d5](1af22d5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://dhis2.atlassian.net/browse/DHIS2-15441
Depends on: dhis2/analytics#1510
Depends on: dhis2/maps-app#2936
Depends on: dhis2/maps-app#2937
Replace the old d2-ui interpretations component with the one in analytics used by DV and LL. With this change, the old d2-ui sharing dialog is also replaced with the new one from ui.
Screenshots:
New:
Old:
Looking at one interpretation:
New:
Old:
Two old features were removed:
Show previous interpretationsbutton. This button toggled whether max 5 interpretations are shown, or all are shown.zip file size improvements:
Old zip file: 5057221
New zip file: 3575577 (29% smaller)
chunks (build/static/js/xyz.js)
Old
3053115 Jun 23 13:58 8877.6fc0d050.chunk.js
New:
1665003 Jun 23 13:55 396.371a423b.chunk.js (45% smaller)
Old source-map-explorer for dependencies bundle (all the dependencies in red were only there bc of the old interpretations component):
New source-map-explorer for dependencies bundle (all those red dependencies were removed):
