fix: backport org unit/period filter, PT plugin, ItemSelector #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an overflow issue in the ItemSelector,the actual fix is in @dhis2/ui, so a bump to latest version solves the issue. (cherry picked from commit 45435b8)
Fixes https://dhis2.atlassian.net/browse/DHIS2-13816. The OrgUnitDialog from analytics had a breaking change in v21.0.0, a different set of props is needed to make it work. Several Cypress tests were updated to work with the new OrgUnitDimension component. There are still 4 cypress tests failing because of a real bug in the app. (cherry picked from commit c1ce958)
(cherry picked from commit 7926d5a)
|
🚀 Deployed on https://pr-2124--dhis2-dashboard.netlify.app |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jenniferarnesen
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the following tickets:
https://dhis2.atlassian.net/browse/DHIS2-13811
https://dhis2.atlassian.net/browse/DHIS2-13812
https://dhis2.atlassian.net/browse/DHIS2-13816