chore: pass GITHUB_TOKEN as env param #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question, do we still need the GH_TOKEN defined at the top? |
jenniferarnesen
approved these changes
Sep 27, 2022
|
🚀 Deployed on https://pr-2115--dhis2-dashboard.netlify.app |
jenniferarnesen
pushed a commit
that referenced
this pull request
Sep 27, 2022
jenniferarnesen
added a commit
that referenced
this pull request
Sep 27, 2022
|
🎉 This PR is included in version 99.9.15 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
edoardo
pushed a commit
that referenced
this pull request
Sep 29, 2022
edoardo
added a commit
that referenced
this pull request
Sep 29, 2022
* chore: pass GITHUB_TOKEN as env param (#2115) (#2116) Co-authored-by: Martin <martin@moid.se> (cherry picked from commit 578c3ca) * fix: fix ItemSelector overflow issue DHIS2-13811 (#2112) Fixes an overflow issue in the ItemSelector,the actual fix is in @dhis2/ui, so a bump to latest version solves the issue. (cherry picked from commit 45435b8) * fix: org unit filter dialog crash (DHIS2-13816) (#2118) Fixes https://dhis2.atlassian.net/browse/DHIS2-13816. The OrgUnitDialog from analytics had a breaking change in v21.0.0, a different set of props is needed to make it work. Several Cypress tests were updated to work with the new OrgUnitDimension component. There are still 4 cypress tests failing because of a real bug in the app. (cherry picked from commit c1ce958) * chore: bump DV plugin and analytics deps DHIS2-13812 (#2123) (cherry picked from commit 7926d5a) Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
GITHUB_TOKENto Cypress test GH action, as done here in DV: dhis2/data-visualizer-app#2127