Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/revamp] Installation #402

Merged
merged 18 commits into from
Jan 18, 2023
Merged

[docs/revamp] Installation #402

merged 18 commits into from
Jan 18, 2023

Conversation

Rajakavitha1
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 commented Jan 15, 2023

resolves #393
Partially addresses: #302

Note: Create and edit docs in the main branch when you can, so that we only cherry-pick out of main, not into main.
-->

@netlify
Copy link

netlify bot commented Jan 15, 2023

Deploy Preview for dgraph-docs-repo ready!

Name Link
🔨 Latest commit 270c6cb
🔍 Latest deploy log https://app.netlify.com/sites/dgraph-docs-repo/deploys/63c789d6f610960007233e62
😎 Deploy Preview https://deploy-preview-402--dgraph-docs-repo.netlify.app/installation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@darkn3rd
Copy link
Contributor

While we want to encourage use of Dgraph and synergy across technology, Dgraph officially should NEVER be officially supported on a non-HA environment for production environments. HA environment means external persistent storage, automatic recovery of failed services, automatic recovery of failed systems (e.g. virtual machines), and highly recommended disaster recovery (backup/restore or export/import with automation). For development environments, local compiled binaries or containers are fine, leaving the system up to the imagination of the developer.

If we do document single systems for production, this should be in some unofficial or unsupported zone that is clear.

@Rajakavitha1
Copy link
Contributor Author

While we want to encourage use of Dgraph and synergy across technology, Dgraph officially should NEVER be officially supported on a non-HA environment for production environments. HA environment means external persistent storage, automatic recovery of failed services, automatic recovery of failed systems (e.g. virtual machines), and highly recommended disaster recovery (backup/restore or export/import with automation). For development environments, local compiled binaries or containers are fine, leaving the system up to the imagination of the developer.

If we do document single systems for production, this should be in some unofficial or unsupported zone that is clear.

Hi, @darkn3rd and @rderbier could you please use the suggestions feature in the GithubUI to make specific changes to the lines that are documented so that it is easy to establish a context and commit the changes to save one more iteration of reviews?

Copy link
Contributor

@damonfeldman damonfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the sections I understand, but don't think I'm expert enough to weigh in on k8s or docker swarm.

content/installation/single-host-setup.md Show resolved Hide resolved
content/installation/download.md Outdated Show resolved Hide resolved
content/installation/single-host-setup.md Show resolved Hide resolved
content/installation/single-host-setup.md Outdated Show resolved Hide resolved
content/_index.md Outdated Show resolved Hide resolved
content/installation/_index.md Outdated Show resolved Hide resolved
content/installation/download.md Outdated Show resolved Hide resolved
content/installation/download.md Outdated Show resolved Hide resolved
content/installation/download.md Outdated Show resolved Hide resolved
content/installation/kubernetes.md Show resolved Hide resolved
content/installation/multi-host-setup.md Show resolved Hide resolved
content/installation/single-host-setup.md Show resolved Hide resolved
content/installation/download.md Outdated Show resolved Hide resolved
content/installation/kubernetes.md Show resolved Hide resolved
Rajakavitha1 and others added 6 commits January 17, 2023 13:32
Co-authored-by: Raphael <rderbier@gmail.com>
Co-authored-by: Raphael <rderbier@gmail.com>
Co-authored-by: Raphael <rderbier@gmail.com>
Co-authored-by: Raphael <rderbier@gmail.com>
Co-authored-by: Raphael <rderbier@gmail.com>
Co-authored-by: Raphael <rderbier@gmail.com>
@Rajakavitha1
Copy link
Contributor Author

I reviewed the sections I understand, but don't think I'm expert enough to weigh in on k8s or docker swarm.

Thanks for the review @damonfeldman !!! the k8s and docker swarm sections are only moved to the install directory in the new IA. Those need a rewrite as well.

Copy link
Contributor

@damonfeldman damonfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some <IP/VARS> used but not defined, or defined and not used.

content/installation/single-host-setup.md Outdated Show resolved Hide resolved
content/installation/single-host-setup.md Outdated Show resolved Hide resolved
content/installation/single-host-setup.md Outdated Show resolved Hide resolved
content/installation/single-host-setup.md Outdated Show resolved Hide resolved
content/installation/download.md Outdated Show resolved Hide resolved
Co-authored-by: Raphael <rderbier@gmail.com>
content/installation/_index.md Outdated Show resolved Hide resolved
content/installation/single-host-setup.md Show resolved Hide resolved
@Rajakavitha1 Rajakavitha1 merged commit 665660f into main Jan 18, 2023
@Rajakavitha1 Rajakavitha1 deleted the revamp/single-host-rajie branch January 18, 2023 05:57
@rderbier rderbier restored the revamp/single-host-rajie branch January 18, 2023 15:22
@rderbier rderbier deleted the revamp/single-host-rajie branch January 18, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

revamp - Dgraph Installation
5 participants