Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor any examples that's using docker-machine commands #302

Closed
kevinmingtarja opened this issue Oct 7, 2022 · 1 comment
Closed

Refactor any examples that's using docker-machine commands #302

kevinmingtarja opened this issue Oct 7, 2022 · 1 comment
Assignees
@Rajakavitha1
Labels
investigate

Comments

@kevinmingtarja
Copy link
Contributor

https://dgraph.io/docs/deploy/single-host-setup/#run-using-docker-compose-on-single-aws-instance
https://dgraph.io/docs/deploy/multi-host-setup/

These two sections still uses the docker-machine command, which is depecrated (docker/machine#4537) and replaced by Docker Desktop now. So, we should refactor these examples so that the readers are not confused.
@kevinmingtarja kevinmingtarja changed the title Refactor any instances of docker-machine commands Refactor any examples that's using docker-machine commands Oct 7, 2022
@Rajakavitha1 Rajakavitha1 self-assigned this Jan 3, 2023
@Rajakavitha1 Rajakavitha1 mentioned this issue Jan 15, 2023
Merged
Rajakavitha1 added a commit that referenced this issue Jan 18, 2023
@Rajakavitha1 @rderbier
[docs/revamp] Installation (#402)
665660f 
resolves #393
Partially addresses: #302

Note: Create and edit docs in the `main` branch when you can, so that we
only cherry-pick out of `main`, not into `main`.
-->

Co-authored-by: Raphael <rderbier@gmail.com>
@Rajakavitha1
Copy link
Contributor

@kevinmingtarja closing this issue because this has been addressed in #439.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rajakavitha1 Rajakavitha1

Labels
investigate
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MichelDiz @Rajakavitha1 @kevinmingtarja