Skip to content

Commit

Permalink
Fix config reload in skaffold dev
Browse files Browse the repository at this point in the history
Fix GoogleContainerTools#2278

Signed-off-by: David Gageot <david@gageot.net>
  • Loading branch information
dgageot committed Jun 19, 2019
1 parent 14bf34e commit 41c3851
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions cmd/skaffold/app/cmd/dev.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,11 @@ func doDev(ctx context.Context, out io.Writer) error {
}
}
}
if err != nil {
if errors.Cause(err) == runner.ErrorConfigurationChanged {
return err
}

if err != nil && errors.Cause(err) != runner.ErrorConfigurationChanged {
r.RPCServerShutdown()
return alwaysSucceedWhenCancelled(ctx, err)
}
r.RPCServerShutdown()
}
}
}

0 comments on commit 41c3851

Please sign in to comment.