Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing skaffold.yaml stops skaffold dev #2278

Closed
dgageot opened this issue Jun 18, 2019 · 0 comments · Fixed by #2279
Closed

Changing skaffold.yaml stops skaffold dev #2278

dgageot opened this issue Jun 18, 2019 · 0 comments · Fixed by #2279
Assignees
@dgageot
Labels
kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.

Comments

@dgageot
Copy link
Contributor

dgageot commented Jun 18, 2019 •
edited
Loading

Changing the content of skaffold.yaml used to restart the dev loop. Now, it exits with this error:

FATA[0197] calling final callback: configuration changed
@dgageot dgageot added kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it. labels Jun 18, 2019
@dgageot dgageot self-assigned this Jun 18, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 18, 2019
@dgageot
Fix config reload in skaffold dev
eefb0d1 
Fix GoogleContainerTools#2278

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this issue Jun 18, 2019
Merged
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 18, 2019
@dgageot
Fix config reload in skaffold dev
861c297 
Fix GoogleContainerTools#2278

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 18, 2019
@dgageot
Fix config reload in skaffold dev
133e6ff 
Fix GoogleContainerTools#2278

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 19, 2019
@dgageot
Fix config reload in skaffold dev
41c3851 
Fix GoogleContainerTools#2278

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 19, 2019
@dgageot
Fix config reload in skaffold dev
69489d8 
Fix GoogleContainerTools#2278

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit that referenced this issue Jun 20, 2019
@dgageot
Fix config reload in skaffold dev (#2279)
ee24699 
* Fix config reload in skaffold dev

Fix #2278

Signed-off-by: David Gageot <david@gageot.net>

* Remember a deployment was made

Signed-off-by: David Gageot <david@gageot.net>

* Initialize event server only once

And only stop it at the end.
Fix #2281

Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix config reload in skaffold dev dgageot/skaffold
1 participant
@dgageot