frontend serving

[hansl]

No description provided.

[hansl]

@paulyoung This probably will not require a CORS because you can do requests to the same server that's serving your javascript.

[paulyoung]

I need to bring my feature branch up to date with master before I can try this, so doing that first and then will see if it unblocks me regarding CORS.

[paulyoung]

I tried merging this into my local branch and got this:

⠁ Starting up the client...
binding to: V4(127.0.0.1:8000)
client: "http://localhost:8080/api"
thread '<unnamed>' panicked at 'System is not running', /nix/store/drq62qf7c389j8j82d69zysm7ljffjyj-crates-io/actix-rt-0.2.5/src/system.rs:78:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
Starting /Users/paulyoung/.cache/dfinity/versions/0.2.0/client /Users/paulyoung/.cache/dfinity/versions/0.2.0/nodemanager /Users/paulyoung⠂ Pinging the DFINITY client...
thread 'main' panicked at 'Invalid client URL.: RelativeUrlWithoutBase', src/libcore/result.rs:999:5

[paulyoung]

I was able to reproduce on this branch with the following steps:

1. cd sdk && nix-build $using_cache

For me this ended with:

...
/nix/store/l8i4m852dwbm4cjgy0zsw6ba2vkz000z-dfinity-sdk-rust
/nix/store/z0snx52xwh9l1f1m8r38d1j613hrm2pi-dfinity-sdk-rust

2. cd dfx/examples/hello and edit dfinity.json:

diff --git a/dfx/examples/hello/dfinity.json b/dfx/examples/hello/dfinity.json
index 43af7a8..4cbb895 100644
--- a/dfx/examples/hello/dfinity.json
+++ b/dfx/examples/hello/dfinity.json
@@ -1,7 +1,18 @@
 {
+  "dfx": "{dfx_version}",
   "canisters": {
     "hello": {
       "main": "app/canisters/hello/main.as"
     }
+  },
+  "defaults": {
+    "build": {
+      "output": "build/"
+    },
+    "start": {
+      "port": 8000,
+      "address": "127.0.0.1",
+      "serve_root": "app/"
+    }
   }
 }

3. Try using the first nix store path:

$ /nix/store/l8i4m852dwbm4cjgy0zsw6ba2vkz000z-dfinity-sdk-rust/bin/dfx start
⠁ Starting up the client...
binding to: V4(127.0.0.1:8000)
client: "http://localhost:8080/api"
thread '<unnamed>' panicked at 'thread 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }<unnamed>', ' panicked at 'src/libcore/result.rsSystem is not running:999', :/nix/store/drq62qf7c389j8j82d69zysm7ljffjyj-crates-io/actix-rt-0.2.5/src/system.rs5:
78note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
⠂ Pinging the DFINITY client...
thread 'main' panicked at 'Invalid client URL.: RelativeUrlWithoutBase', src/libcore/result.rs:999:5

4. Try using the second one:

$ /nix/store/z0snx52xwh9l1f1m8r38d1j613hrm2pi-dfinity-sdk-rust/bin/dfx start
⠁ Starting up the client...
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:999:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
binding to: V4(127.0.0.1:8000)
client: "http://localhost:8080/api"
⠂ Pinging the DFINITY client...
thread 'main' panicked at 'Invalid client URL.: RelativeUrlWithoutBase', src/libcore/result.rs:999:5

[paulyoung]

I missed "version": 1, in dfinity.json but get similar results after that:

$ /nix/store/l8i4m852dwbm4cjgy0zsw6ba2vkz000z-dfinity-sdk-rust/bin/dfx start
⠁ Starting up the client...
binding to: V4(127.0.0.1:8000)
client: "http://localhost:8080/api"
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:999:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
⠂ Pinging the DFINITY client...
thread 'main' panicked at 'Invalid client URL.: RelativeUrlWithoutBase', src/libcore/result.rs:999:5

$ /nix/store/z0snx52xwh9l1f1m8r38d1j613hrm2pi-dfinity-sdk-rust/bin/dfx start
⠁ Starting up the client...
binding to: V4(127.0thread '.<unnamed>0' panicked at '.called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }1', :src/libcore/result.rs8000)
client: "http://localhost:8080/api"
:999:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
⠂ Pinging the DFINITY client...
thread 'main' panicked at 'Invalid client URL.: RelativeUrlWithoutBase', src/libcore/result.rs:999:5

[paulyoung]

I fixed {dfx_version} too, but no joy:

$ cat examples/hello/dfinity.json
{
  "version": 1,
  "dfx": "0.2.0",
  "canisters": {
    "hello": {
      "main": "app/canisters/hello/main.as"
    }
  },
  "defaults": {
    "build": {
      "output": "build/"
    },
    "start": {
      "port": 8000,
      "address": "127.0.0.1",
      "serve_root": "app/"
    }
  }
}

$ /nix/store/l8i4m852dwbm4cjgy0zsw6ba2vkz000z-dfinity-sdk-rust/bin/dfx start
⠁ Starting up the client...
binding to: V4(127.0.0.1:8000)
client: "http://localhost:8080/api"
thread '<unnamed>' panicked at 'System is not running', /nix/store/drq62qf7c389j8j82d69zysm7ljffjyj-crates-io/actix-rt-0.2.5/src/system.rs:78:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
⠂ Pinging the DFINITY client...
thread 'main' panicked at 'Invalid client URL.: RelativeUrlWithoutBase', src/libcore/result.rs:999:5

[paulyoung]

I added http:// to the address, making it "address": "http://127.0.0.1", and got a bit further it seems:

$ /nix/store/l8i4m852dwbm4cjgy0zsw6ba2vkz000z-dfinity-sdk-rust/bin/dfx start
⠁ Starting up the client...
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:347:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[paulyoung]

I also tried using the --host flag:

$ RUST_BACKTRACE=1 /nix/store/z0snx52xwh9l1f1m8r38d1j613hrm2pi-dfinity-sdk-rust/bin/dfx start --host http://127.0.0.1:8000
⠁ Starting up the client...
An error occured:
AddrParseError(
    AddrParseError(
        (),
    ),
)

[hansl]

@paulyoung This should be fixed.

[paulyoung]

Still seeing this:

$ dfx start
⠁ Starting up the client...
binding to: V4(127.0.0.1:8000)
client: "http://localhost:8080/api"
thread '<unnamed>' panicked at 'System is not running', /nix/store/drq62qf7c389j8j82d69zysm7ljffjyj-crates-io/actix-rt-0.2.5/src/system.rs:78:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
Starting /Users/paulyoung/.cache/dfinity/versions/0.2.0/client /Users/paulyoung/.cache/dfinity/versions/0.2.0/nodemanager /Users/paulyoung/.cache/dfinity/vers⠂ Pinging the DFINITY client...
thread 'main' panicked at 'Invalid client URL.: RelativeUrlWithoutBase', src/libcore/result.rs:999:5

[paulyoung]

That was with:

$ dfx new foo
$ cd foo
$ dfx start

[paulyoung]

Never mind, I don't have the latest changes. I did git merge origin/hansl/frontend-serving but forgot to fetch first.

Trying again.

[paulyoung]

I'm still running into CORS issues:

After the above I tried setting mode: "same-origin" and got: Fetch API cannot load http://localhost:8080/api/v1/submit. Request mode is "same-origin" but the URL's origin is not same as the request origin http://localhost:8000.

The port is part of the origin.

[hansl]

Yes use the 8000 port

…

Sent from my iPhone

On Sep 30, 2019, at 12:18, Paul Young ***@***.***> wrote:  I'm still running into CORS issues: After the above I tried setting mode: "same-origin" and got: Fetch API cannot load http://localhost:8080/api/v1/submit. Request mode is "same-origin" but the URL's origin is not same as the request origin http://localhost:8000. The port is part of the origin. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.