Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Publich Launchpad #1776

Merged
merged 2 commits into from
Jan 28, 2023
Merged

Fix: Publich Launchpad #1776

merged 2 commits into from
Jan 28, 2023

Conversation

lmuntaner
Copy link
Contributor

Motivation

Non logged in users can access Launchpad.

Changes

  • Do not call loadSnsSwapCommitments if not logged in.

Tests

  • Add test for this case.

peterpeterparker
peterpeterparker approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@lmuntaner lmuntaner merged commit a86ec35 into main Jan 28, 2023
@lmuntaner lmuntaner deleted the fix_LM_bug branch January 28, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @peterpeterparker