Fix: Publich Launchpad (#1776)

# Motivation Non logged in users can access Launchpad. # Changes * Do not call loadSnsSwapCommitments if not logged in. # Tests * Add test for this case.
dfinity · Jan 28, 2023 · a86ec35 · a86ec35
1 parent fb05ceb
commit a86ec35
Show file tree

Hide file tree

Showing 2 changed files with 71 additions and 34 deletions.
diff --git a/frontend/src/lib/pages/Launchpad.svelte b/frontend/src/lib/pages/Launchpad.svelte
@@ -4,12 +4,19 @@
   import { i18n } from "$lib/stores/i18n";
   import { SnsSwapLifecycle } from "@dfinity/sns";
   import { snsProjectsCommittedStore } from "$lib/derived/sns/sns-projects.derived";
-  import { onMount } from "svelte";
   import { loadSnsSwapCommitments } from "$lib/services/sns.services";
+  import { authStore } from "$lib/stores/auth.store";
+  import { isSignedIn } from "$lib/utils/auth.utils";
 
-  onMount(() => {
-    loadSnsSwapCommitments();
-  });
+  const loadSnsSale = async () => {
+    if (!isSignedIn($authStore.identity)) {
+      return;
+    }
+
+    await loadSnsSwapCommitments();
+  };
+
+  $: $authStore.identity, (async () => await loadSnsSale())();
 
   let showCommitted = false;
   $: showCommitted = ($snsProjectsCommittedStore?.length ?? []) > 0;

diff --git a/frontend/src/tests/lib/pages/Launchpad.spec.ts b/frontend/src/tests/lib/pages/Launchpad.spec.ts
@@ -4,8 +4,9 @@
 
 import { snsProjectsCommittedStore } from "$lib/derived/sns/sns-projects.derived";
 import Launchpad from "$lib/pages/Launchpad.svelte";
+import { loadSnsSwapCommitments } from "$lib/services/sns.services";
 import { authStore } from "$lib/stores/auth.store";
-import { render } from "@testing-library/svelte";
+import { render, waitFor } from "@testing-library/svelte";
 import {
   authStoreMock,
   mockIdentity,
@@ -30,42 +31,71 @@ jest.mock("$lib/services/sns.services", () => {
 });
 
 describe("Launchpad", () => {
-  jest
-    .spyOn(authStore, "subscribe")
-    .mockImplementation(mutableMockAuthStoreSubscribe);
+  describe("signed in", () => {
+    jest
+      .spyOn(authStore, "subscribe")
+      .mockImplementation(mutableMockAuthStoreSubscribe);
 
-  beforeAll(() =>
-    authStoreMock.next({
-      identity: mockIdentity,
-    })
-  );
+    beforeAll(() =>
+      authStoreMock.next({
+        identity: mockIdentity,
+      })
+    );
 
-  afterEach(() => jest.clearAllMocks());
+    afterEach(() => jest.clearAllMocks());
 
-  it("should render titles", () => {
-    jest
-      .spyOn(snsProjectsCommittedStore, "subscribe")
-      .mockImplementation(mockProjectSubscribe([mockSnsFullProject]));
-    const { getByText } = render(Launchpad);
-
-    // TBU
-    expect(getByText(en.sns_launchpad.open_projects)).toBeInTheDocument();
-    expect(getByText(en.sns_launchpad.committed_projects)).toBeInTheDocument();
-    expect(getByText(en.sns_launchpad.proposals)).toBeInTheDocument();
+    it("should render titles", () => {
+      jest
+        .spyOn(snsProjectsCommittedStore, "subscribe")
+        .mockImplementation(mockProjectSubscribe([mockSnsFullProject]));
+      const { getByText } = render(Launchpad);
+
+      // TBU
+      expect(getByText(en.sns_launchpad.open_projects)).toBeInTheDocument();
+      expect(
+        getByText(en.sns_launchpad.committed_projects)
+      ).toBeInTheDocument();
+      expect(getByText(en.sns_launchpad.proposals)).toBeInTheDocument();
+    });
+
+    it("should call loadSnsSwapCommitments", async () => {
+      render(Launchpad);
+
+      await waitFor(() => expect(loadSnsSwapCommitments).toHaveBeenCalled());
+    });
+
+    it("should not render committed project title if no committed projects", () => {
+      jest
+        .spyOn(snsProjectsCommittedStore, "subscribe")
+        .mockImplementation(mockProjectSubscribe([]));
+
+      const { queryByText } = render(Launchpad);
+
+      // TBU
+      expect(queryByText(en.sns_launchpad.open_projects)).toBeInTheDocument();
+      expect(
+        queryByText(en.sns_launchpad.committed_projects)
+      ).not.toBeInTheDocument();
+      expect(queryByText(en.sns_launchpad.proposals)).toBeInTheDocument();
+    });
   });
 
-  it("should not render committed project title if no committed projects", () => {
+  describe("not logged in", () => {
     jest
-      .spyOn(snsProjectsCommittedStore, "subscribe")
-      .mockImplementation(mockProjectSubscribe([]));
+      .spyOn(authStore, "subscribe")
+      .mockImplementation(mutableMockAuthStoreSubscribe);
 
-    const { queryByText } = render(Launchpad);
+    beforeAll(() =>
+      authStoreMock.next({
+        identity: undefined,
+      })
+    );
+    it("should not call loadSnsSwapCommitments", async () => {
+      render(Launchpad);
 
-    // TBU
-    expect(queryByText(en.sns_launchpad.open_projects)).toBeInTheDocument();
-    expect(
-      queryByText(en.sns_launchpad.committed_projects)
-    ).not.toBeInTheDocument();
-    expect(queryByText(en.sns_launchpad.proposals)).toBeInTheDocument();
+      await waitFor(() =>
+        expect(loadSnsSwapCommitments).not.toHaveBeenCalled()
+      );
+    });
   });
 });