Re-enable use of memory.grow on drun
#694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires https://github.com/dfinity-lab/dfinity/pull/1270 Also use a `drun` config file to set absurd gas limits.
now that https://github.com/dfinity-lab/dfinity/pull/1270 is merged.
|
The test case takes 1m32s on my laptop. (partly because we also run it interpreted three times). Not sure if that’s worth it. |
ggreif
reviewed
Oct 17, 2019
default.nix
Outdated
| @@ -33,7 +33,7 @@ let dev = import (builtins.fetchGit { | |||
| let dfinity-repo = import (builtins.fetchGit { | |||
| url = "ssh://git@github.com/dfinity-lab/dfinity"; | |||
| ref = "master"; | |||
| rev = "a50367859416ef7c12ca103b7fc03f5a7654f6ad"; | |||
| rev = "1b7e7c185fdd20a61b13e4c76d4dde29dce9862e"; | |||
There was a problem hiding this comment.
This will need a bump (probably).
Is that because of the high limit (allocation costs)? Why not reduce it to a reasonable size then? |
|
Oh, I didn’t get this in? Thanks for pinging me. |
ggreif
approved these changes
Oct 17, 2019
dfinity-bot
added a commit
that referenced
this pull request
Mar 5, 2025
## Changelog for motoko-base: Branch: next-moc Commits: [dfinity/motoko-base@8fd23fa7...a3dd04eb](dfinity/motoko-base@8fd23fa...a3dd04e) * [`cee15564`](dfinity/motoko-base@cee1556) feat: add `isReplicated` to `ExperimentalInternetComputer` ([dfinity/motoko-base#694](https://togithub.com/dfinity/motoko-base/issues/694)) * [`c9a08167`](dfinity/motoko-base@c9a0816) feat: add `Error.isRetryPossible`, a predicate for non-fatal messaging errors ([dfinity/motoko-base#692](https://togithub.com/dfinity/motoko-base/issues/692)) * [`6246b654`](dfinity/motoko-base@6246b65) feat: make `replyDeadline` an optional return type ([dfinity/motoko-base#693](https://togithub.com/dfinity/motoko-base/issues/693)) * [`1a381b99`](dfinity/motoko-base@1a381b9) Motoko 0.14.3 * [`756855bc`](dfinity/motoko-base@756855b) chore: amend the 0.14.3 changelog ([dfinity/motoko-base#697](https://togithub.com/dfinity/motoko-base/issues/697))
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
## Changelog for motoko-base: Branch: next-moc Commits: [dfinity/motoko-base@8fd23fa7...a3dd04eb](dfinity/motoko-base@8fd23fa...a3dd04e) * [`cee15564`](dfinity/motoko-base@cee1556) feat: add `isReplicated` to `ExperimentalInternetComputer` ([dfinity/motoko-base#694](https://togithub.com/dfinity/motoko-base/issues/694)) * [`c9a08167`](dfinity/motoko-base@c9a0816) feat: add `Error.isRetryPossible`, a predicate for non-fatal messaging errors ([dfinity/motoko-base#692](https://togithub.com/dfinity/motoko-base/issues/692)) * [`6246b654`](dfinity/motoko-base@6246b65) feat: make `replyDeadline` an optional return type ([dfinity/motoko-base#693](https://togithub.com/dfinity/motoko-base/issues/693)) * [`1a381b99`](dfinity/motoko-base@1a381b9) Motoko 0.14.3 * [`756855bc`](dfinity/motoko-base@756855b) chore: amend the 0.14.3 changelog ([dfinity/motoko-base#697](https://togithub.com/dfinity/motoko-base/issues/697))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires https://github.com/dfinity-lab/dfinity/pull/1270
Also use a
drunconfig file to set absurd gas limits.