Consolidate flags from codegen into as_config #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
changed the title
|
LGTM and I actually want this soon so I can use the flag in the type checker and clean up the platform flag in async.ml |
nomeata
approved these changes
Sep 28, 2019
| let trace = ref false | ||
| let verbose = ref false | ||
| let print_depth = ref 2 | ||
| let release_mode = ref false | ||
| let compile_mode = ref ICMode | ||
| let multi_value = ref false |
There was a problem hiding this comment.
I thought it was a feature that flags that only affect one module/library should be there. But consistency is the something something hobgoblin. So not a big deal either way.
|
|
dfinity-bot
added a commit
that referenced
this pull request
Mar 5, 2025
## Changelog for motoko-base: Branch: next-moc Commits: [dfinity/motoko-base@8fd23fa7...a3dd04eb](dfinity/motoko-base@8fd23fa...a3dd04e) * [`cee15564`](dfinity/motoko-base@cee1556) feat: add `isReplicated` to `ExperimentalInternetComputer` ([dfinity/motoko-base#694](https://togithub.com/dfinity/motoko-base/issues/694)) * [`c9a08167`](dfinity/motoko-base@c9a0816) feat: add `Error.isRetryPossible`, a predicate for non-fatal messaging errors ([dfinity/motoko-base#692](https://togithub.com/dfinity/motoko-base/issues/692)) * [`6246b654`](dfinity/motoko-base@6246b65) feat: make `replyDeadline` an optional return type ([dfinity/motoko-base#693](https://togithub.com/dfinity/motoko-base/issues/693)) * [`1a381b99`](dfinity/motoko-base@1a381b9) Motoko 0.14.3 * [`756855bc`](dfinity/motoko-base@756855b) chore: amend the 0.14.3 changelog ([dfinity/motoko-base#697](https://togithub.com/dfinity/motoko-base/issues/697))
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
## Changelog for motoko-base: Branch: next-moc Commits: [dfinity/motoko-base@8fd23fa7...a3dd04eb](dfinity/motoko-base@8fd23fa...a3dd04e) * [`cee15564`](dfinity/motoko-base@cee1556) feat: add `isReplicated` to `ExperimentalInternetComputer` ([dfinity/motoko-base#694](https://togithub.com/dfinity/motoko-base/issues/694)) * [`c9a08167`](dfinity/motoko-base@c9a0816) feat: add `Error.isRetryPossible`, a predicate for non-fatal messaging errors ([dfinity/motoko-base#692](https://togithub.com/dfinity/motoko-base/issues/692)) * [`6246b654`](dfinity/motoko-base@6246b65) feat: make `replyDeadline` an optional return type ([dfinity/motoko-base#693](https://togithub.com/dfinity/motoko-base/issues/693)) * [`1a381b99`](dfinity/motoko-base@1a381b9) Motoko 0.14.3 * [`756855bc`](dfinity/motoko-base@756855b) chore: amend the 0.14.3 changelog ([dfinity/motoko-base#697](https://togithub.com/dfinity/motoko-base/issues/697))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit noisy PR that I wanted to leave out of #684. It makes flag handling less diverse. Mostly mechanical changes. No functional impact.