-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging dev into master #5272
Merged
Merged
Merging dev into master #5272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' by resolving it
EES-5506 fix data-catalogue footnotes rendering html as plain text
EES-5464 Download data-catalogue CSV with code UI
This addresses excessive generation of `anyOf` or `allOf`, which were occurring due to various options we had enabled. We have now opted for more explicit declarations using annotations to have better control over the generated types.
This adds a new `SwaggerEnum` serializer option to insert enum schemas as refs. This means that we don't have to serialize all enum values alongside the schema property and can simply reference the enum schema itself.
…ion` This was caused by the `MicroElements.Swashbuckle` package not detecting properties correctly for `DataSetQueryLocation` subtypes due to Swashbuckle generating the inheritance model with `allOf`. We've fixed this by converting `DataSetQueryLocation` to an interface. This is more repetitive but also works a bit nicer when parsing the schema in the public API docs site.
In the public API, we now alias: - `GeographicLevel` as `GeographicLevelCode` - `TimeIdentifier` as `TimeIdentifierCode` This naming aligns better with the public API, where both of these enums are only used in their code forms (and are referenced as such in the documentation).
This is primarily to make it easier for users to write data set queries by allowing them to comment their various criteria, which are typically hard to understand due to the use of public IDs.
EES-5494 Update Swagger documentation to work with public API docs site
…tions' by resolving it & Finalization of API datasets
…-education-statistics into EES-5485
Merge Master into dev
… removing old access policies
…e rather than Public API url!
…rs-policy EES-5512 - correcting Container App CORS policy to include public site URL rather than Public API url!
…-education-statistics into EES-5512
…-education-statistics into EES-5519
EES-5519 Set up Azure pipelines
EES-5493 Clean up UI test data to fix Public API error occurring when creating Public API data set
…t visible' as per PR comments
EES-5485 Added UI test to validate mapping statuses of 'Map locations…
EES 5512 - Verify and update 'Changelog guidance notes' and 'Version History' of an API dataset
EES-5464 replace CSV download rewrite with middleware redirect
This updates the sort field format to `filter|{id}` (for filters) and `indicator|{id}` (for indicators). We need to change the format as filter and indicator public IDs can potentially collide using sqids so we need to remove any ambiguity by specifying the type.
EES-5518 Add server URL to OpenAPI docs
N-moh
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.