EES-5506 fix data-catalogue footnotes rendering html as plain text #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmyoungman
approved these changes
Sep 13, 2024
| @@ -14,7 +15,9 @@ export default function DataSetFileFootnotes({ footnotes }: Props) { | |||
| <DataSetFilePageSection heading={pageSections[sectionId]} id={sectionId}> | |||
| <ol> | |||
| {footnotes.map(footnote => ( | |||
| <li key={footnote.id}>{footnote.label}</li> | |||
| <li key={footnote.id}> | |||
| <ContentHtml html={footnote.label} /> | |||
There was a problem hiding this comment.
I think we run all footnotes through the sanitizeHtml before this, so there is no need to do it here, but just raising it to double check before merging.
With footnotes only being created by analysts anyway, this isn't really much of a risk regardless.
There was a problem hiding this comment.
ContentHtml is sanitizing, so ignore this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Footnotes rendering html as plain text in data catalogue pages.
Implementation now follows suit with other footnote rendering using
<ContentHtml / >to render footnote labels