Merge dev into master #5105
Merged
Merge dev into master #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing API data sets tab link if user is BAU
…ct-release-approval-while-mapping-in-progress EES-4956 - amending wording of release checklist errors and only show…
EES-5324 api data set locations mapping page
…t clearer This now more closely resembles the new pattern I'll be introducing for the API subscriptions. Trying to keep these as consistent as possible without a large refactor of the current stuff
… the new Azure.Data.tables package
The `INotificationClientProvider` was somewhat unnecessary, and caused the need for unnecessary setup in both the business logic and tests. We have simplified this by removing this class and injecting the `INotificiationClient` at startup. Only the `EmailClient` needs access to this - so now we only need to mock the `IEmailService` in our integration tests (because we don't want to run our tests against the real Notify project, which is a third-party dependency).
…98d1352' that was missed from rebase
…RowKey` to be the Data Set ID
… `INotificationClient` instead
…sistence in tests
…ID, and the `RowKey` as the email
…t expired before verifying
EES-5251 fix accessibility page ui test
EES-4929 Adding endpoint to unsubscribe users from API data sets
EES-5220 fix find stats search ui test
🐛 EES-5329 Ensure `app_public_data_api` has `USAGE` privilege on public schema
…ssing-vnet EES-4928 - adding missing vnet to main ARM template
…-master-conflict Merge master into dev
EES-5364 remove notification banner on data catalogue
This re-models the changelog data models by: - Removing `ChangeSets` - Removing JSONB columns in favour of a standard relational model using foreign keys (i.e. previous / current states). We've moved towards this approach as it allows us to avoid duplicating the entire meta domain in JSONB columns (and respective models). Using normal foreign key references means we can keep things relatively simple. The only issue is that we don't know if this approach will perform well at scale, but we believe it'd be possibel to remedy this with blob caching (or similar). EES-4921 Test filter / location option changes using owned entities
EES-4950 Re-model data set version change sets
…porting of Location metadata, and added appropriate tests to ensure that PublicIds are carried over into the new LocationOptionMetaLinks where mappings have been established.
…porting of Filter Option metadata, and added appropriate tests to ensure that PublicIds are carried over into the new FilterOptionMetaLinks where mappings have been established.
…letionOfNextDataSetVersionFunction
…g to alternate mappings between AutoNone and ManualNone in tests.
…d some quick improvements to Locations test code.
…st-data-generators EES-4954 - add test data generators
…ue-import-with-mappings EES-4954 - continue import of next data set version, using the mappings
…st-snapshots chore(tests): Update test snapshots 26-07-2024
amyb-hiveit
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.