EES-4928 - adding missing vnet to main ARM template #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncan-at-hiveit
force-pushed
the
EES-XXXX-fix-missing-vnet
branch
2 times, most recently
from
749decb to
6c2a62b
Compare
benoutram
approved these changes
Jul 22, 2024
| @@ -1045,6 +1045,8 @@ | |||
| "dataSubnetRef": "[resourceId('Microsoft.Network/virtualNetworks/subnets', variables('vNetName'), variables('dataSubnetName'))]", | |||
| "publicApiDataProcessorSubnetName": "[concat(parameters('subscription'), '-', parameters('environment'), '-papi-snet-fa-processor')]", | |||
| "publicApiDataProcessorSubnetRef": "[resourceId('Microsoft.Network/virtualNetworks/subnets', variables('vNetName'), variables('publicApiDataProcessorSubnetName'))]", | |||
| "publicApiDataProcessorPlinkSubnetName": "[concat(parameters('subscription'), '-', parameters('environment'), '-papi-snet-fa-processor-plink')]", | |||
| "publicApiDataProcessorPlinkSubnetRef": "[resourceId('Microsoft.Network/virtualNetworks/subnets', variables('vNetName'), variables('publicApiDataProcessorPlinkSubnetName'))]", | |||
There was a problem hiding this comment.
There seems to be three unused 'subnetRef' variables already and I can't see where this one's used either. Is that correct?
There was a problem hiding this comment.
removed unused refs, ta
duncan-at-hiveit
force-pushed
the
EES-XXXX-fix-missing-vnet
branch
from
6c2a62b to
f7a7ea0
Compare
benoutram
approved these changes
Jul 22, 2024
duncan-at-hiveit
force-pushed
the
EES-XXXX-fix-missing-vnet
branch
from
f7a7ea0 to
cbba257
Compare
duncan-at-hiveit
force-pushed
the
EES-XXXX-fix-missing-vnet
branch
from
cbba257 to
3b934f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up the inf deploy for EES-4928 by adding the public data processor's private link subnet to the main ARM template.