Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EES-5013 Suppress SQL command console logging in Function apps #5024

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

benoutram
Copy link
Collaborator

@benoutram benoutram commented Jul 2, 2024

This PR suppresses the DbCommand SQL console logging seen in our Azure Function apps when running locally that started occurring after either the change to use the Isolated Worker Model in #4673 or the .NET 8 update in #4639.

This has been making it difficult to spot exceptions and other log messages because they are surrounded by superfluous SQL command logging.

This PR brings the logging config in sync with the Public Data Processor function app where this fix has already been applied.

Note that this doesn't completely close the issue as we still leave a TODO in the code to answer why we can’t we filter Microsoft.EntityFrameworkCore.Database.Command using standard logging config in app settings.

We normally control SQL command logging by setting the Microsoft.EntityFrameworkCore.Database.Command filter in the logging configuration. E.g. to turn it on:

"Microsoft.EntityFrameworkCore.Database.Command": "Debug"

@benoutram benoutram merged commit 4bdbe8d into dev Jul 8, 2024
7 checks passed
@benoutram benoutram deleted the EES-5013 branch July 8, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants