-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EES-4975 Update projects to .NET 8, ASP.NET Core 8, Entity Framework 8 and C# 12 #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbe1f70
to
4139e3b
Compare
4139e3b
to
dfbb869
Compare
mmyoungman
requested changes
Mar 19, 2024
...n.ExploreEducationStatistics.Common/GovUk.Education.ExploreEducationStatistics.Common.csproj
Show resolved
Hide resolved
...tent.Security.Tests/GovUk.Education.ExploreEducationStatistics.Content.Security.Tests.csproj
Show resolved
Hide resolved
2968bf3
to
00383c5
Compare
becd192
to
744690f
Compare
mmyoungman
approved these changes
Mar 21, 2024
…ts use the recommended compiler version for the target framework.
…tion strings (default is false).
…ngs after breaking change to Encrypt defaulting to true in EF Core 7.0.
744690f
to
d2d5907
Compare
…efore Cronos max allowed year 2499.
…roperties. This should fix EES-4445 by setting CORS config consistently across environments.
d2d5907
to
c218bce
Compare
…isher local.settings.json
…cal.settings.json
…e-functions-to-isolated-worker-model EES-4535 Update Data.Processor, Notifier and Publisher function apps to run in Isolated Worker model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the projects (excluding the Public API projects which are already up to date) to use .NET 8, ASP.NET Core 8, Entity Framework Core 8, and set the language version to C# 12.
As well as the update to .NET 8, this PR:
<LangVersion>
from all .csproj files to ensure projects use the recommended compiler version for the target framework. This is C# 12 for .NET 8.0.Automapper
package dependency from v9 to v13 for compatibility with .NET 8. This upgrade is possible afterIdentityServer4.EntityFramework.Storage
was recently removed which was blocking it.AutoMapper.Extensions.Microsoft.DependencyInjection
which is no longer required since AutoMapper v13.CompareNETObjects
package dependency for compatibility with .NET 8.Trusted_Connection=false
from Content database connection strings in local settings, because the default is false.TrustServerCertificate=True
to database connection strings in local settings after breaking change to theEncrypt
parameter (defaulting to true) were introduced by EF Core 7.0.IsExternalInit
package dependency from all projects which hasn't been needed since C# 9.ProblemDetailsResultFilterTests.cs
due to RFC 7231 becoming obsolete, replaced by RFC 9110.SetUnixPermissions
used when creating zip files related to EES-2236 because it's no longer needed.siteConfig
element from withinproperties
. Hoisted several settings which should be withinsiteConfig
which should fix EES-4445 caused by missing/inconsistent CORS config in environments.KeyStatistics
base type and bothKeyStatisticsDataBlock
andKeyStatisticsText
sub-types following breaking change in EF7. See Breaking changes in EF Core 7.0.