Devspace defaults to uploading credentials to cluster #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devspace-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
FabianKramm
reviewed
Nov 8, 2023
pkg/devspace/build/build.go
Outdated
| err = pullsecrets.NewClient().EnsurePullSecret(ctx, dockerClient, ctx.KubeClient().Namespace(), registryURL) | ||
| if err != nil { | ||
| ctx.Log().Errorf("error ensuring pull secret for registry %s: %v", registryURL, err) | ||
| if imageConf.BuildKit != nil && imageConf.BuildKit.InCluster != nil { |
There was a problem hiding this comment.
I don't think this is necessary as buildkit is using the local credentials automatically
…ildkit builds Fixes devspace-sh#2729 Fixes ENG-2185 Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2729
Fixes ENG-2185
What issue type does this pull request address?
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2729
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace creates pull secrets during
devspace buildeven when they are not required.