Skip to content

Commit

Permalink
fix: only upload pull secret credentials for kaniko and in cluster bu…
Browse files Browse the repository at this point in the history
…ildkit builds

Fixes #2729
Fixes ENG-2185

Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
  • Loading branch information
lizardruss committed Nov 8, 2023
1 parent 419d97e commit 4534d20
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions pkg/devspace/build/build.go
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
package build

import (
"strings"

dockerclient "github.com/loft-sh/devspace/pkg/devspace/docker"
"github.com/loft-sh/devspace/pkg/devspace/pullsecrets"
"strings"

"github.com/loft-sh/devspace/pkg/devspace/build/builder"
"github.com/loft-sh/devspace/pkg/devspace/build/types"
Expand Down Expand Up @@ -104,11 +105,6 @@ func (c *controller) Build(ctx devspacecontext.Context, images []string, options
ctx.Log().Errorf("error ensuring pull secret for registry %s: %v", registryURL, err)
}
}

err = pullsecrets.NewClient().EnsurePullSecret(ctx, dockerClient, ctx.KubeClient().Namespace(), registryURL)
if err != nil {
ctx.Log().Errorf("error ensuring pull secret for registry %s: %v", registryURL, err)
}
}
}

Expand Down

0 comments on commit 4534d20

Please sign in to comment.