-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create go 1.19 stack versions #239
Conversation
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
I've put WIP as I'm currently testing my changes |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
I have tested the sample devfile (1.18) with the current 1.2.0 version as parent and I was able to build it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, rm3l, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
This PR creates two new versions for
go
stack:version: 1.2.0
: In order to support backwards compatibility with samples the1.2.0
is a new version of1.1.0
but it is using the golang version 1.19 instead of 1.18.version: 2.2.0
: This is a new version of2.1.0
which is using the golang version 1.19 instead of1.18
.Additionally, this PR adds the
Deprecated
label to the following stack versions as they are using go version 1.18 which is no longer supported. The new default version is the1.2.0
.Which issue(s) this PR fixes:
fixes devfile/api#1300
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: