Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new version for Go stack using golang 1.19 #1300

Closed
5 tasks done
Tracked by #1303
thepetk opened this issue Oct 23, 2023 · 2 comments · Fixed by devfile/registry#239 or devfile-samples/devfile-sample-go-basic#31
Closed
5 tasks done
Tracked by #1303
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@thepetk
Copy link
Contributor

thepetk commented Oct 23, 2023

Which area/kind this issue is related to?

/area registry

Issue Description

As the go version 1.18 is currently EOL, we should update the go stack of the registry to use version 1.19. On the other hand, all versions using 1.18 should be marked as Deprecated by adding a tag in their metatada.tags field.

Acceptance Criteria

  • Create 2 new versions for go stack -> 1.2.0 (to update the default stack version) and 2.2.0 (to update the stack versions having schemaVersion: 2.2.x)
  • Add Deprecated tag to go stack versions 1.0.2, 1.1.0, 2.0.0, 2.1.0.
  • Update the stacks/go/stack.yaml file and set 1.0.2 as the default version.
  • Update the renovate.json file to skip directories stacks/go/1.0.2/, stacks/go/1.1.0/, stacks/go/2.0.0/, stacks/go/2.1.0/ because they will be deprecated
  • Update the https://github.com/devfile-samples/devfile-sample-go-basic to use golang version 1.19 and have as a parent the new version of the go stack.
@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Oct 23, 2023
@thepetk thepetk changed the title Create new version of Go stack using golang 1.19 Create new version for Go stack using golang 1.19 Oct 23, 2023
@thepetk thepetk self-assigned this Oct 26, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Nov 3, 2023

Created a sample PR (devfile-samples/devfile-sample-go-basic#31) which will be merged right after the stack version deployment.

@thepetk
Copy link
Contributor Author

thepetk commented Nov 8, 2023

Re-opening as the sample PR is still under review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure
Projects
Status: Done ✅
1 participant