-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui-library): props alignment form label #949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a unit test is failing for form label. I think you just need to double check the error class that's being applied
c607248
to
8617051
Compare
8617051
to
3f208d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RubirajAccenture ,
the updates look good for the Form Label in Storybook, but I saw that now other components that use the Form Label have a Form label in an error state per default. For example the Text Area is showing a Form Label in error state, even if the Text Are is not in an error state. Could you check that again?
Also I found two small other thing on the Form Label Storybook page:
- All the section titles "Appearance", "Content / Settings" & "Validation" are having a bigger bottom-margin in the table of content than on other pages, resulting in big spaces in-between the table of content
- The example story in the "Label Appendix" section is showing 3 Form Labels in the sizeVariant LG, but other examples are mostly showing the sizeVariant MD. Could you change the "Label Appendix" Story to use MD size for all 3 labels?
3f208d5
to
b8fd833
Compare
b8fd833
to
454a9db
Compare
closes #781