fix(ui-library): props alignment form label

deven-org · Feb 22, 2024 · 8617051 · 8617051
1 parent e459f9f
commit 8617051
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/packages/ui-library/src/components/form-label/index.stories.ts b/packages/ui-library/src/components/form-label/index.stories.ts
@@ -1,6 +1,6 @@
 /* eslint-disable no-console */
 import { Themes } from '../../foundation/_tokens-generated/index.themes';
-import { FormSizes, LabelVariants } from '../../globals/constants';
+import { FormSizes } from '../../globals/constants';
 import { BlrFormLabelType } from './index';
 import { BlrFormLabelRenderFunction } from './renderFunction';
 import { html } from 'lit-html';
@@ -56,13 +56,14 @@ export default {
     },
 
     hasError: {
+      name: 'hasError',
       description: 'Choose if component has an error.',
-      options: LabelVariants,
-      control: { type: 'select' },
+      defaultValue: false,
       table: {
-        category: 'Validation',
+        category: 'Validations',
       },
     },
+
     forValue: {
       description: 'This references the id of the component to which the label is added.',
       control: { type: 'text' },

diff --git a/packages/ui-library/src/components/form-label/index.test.ts b/packages/ui-library/src/components/form-label/index.test.ts
@@ -107,7 +107,7 @@ describe('blr-form-label', () => {
     );
     const blrLabel = querySelectorDeep('label.blr-form-label', element.getRootNode() as HTMLElement);
     const errorLabel = blrLabel?.getAttribute('class');
-    expect(errorLabel).to.contain('true');
+    expect(errorLabel).to.contain('error');
   });
 
   it('has a size md by default', async () => {

diff --git a/packages/ui-library/src/components/form-label/index.ts b/packages/ui-library/src/components/form-label/index.ts
@@ -48,7 +48,7 @@ export class BlrFormLabel extends LitElement {
       const labelClasses = classMap({
         'blr-form-label': true,
         [`${this.sizeVariant}`]: this.sizeVariant,
-        [`${this.hasError}`]: this.hasError,
+        'error': this.hasError,
       });
 
       const spanClasses = classMap({