Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs deploy #40

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Fix docs deploy #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
388cdb5
chore: fix releasing.md
gadomski Oct 10, 2024
a1e27ce
ci: fix docs
gadomski Oct 10, 2024
1ccfb41
ci: don't deploy when the cli tag pushes
gadomski Oct 10, 2024
35c3509
fix: need to fetch all the history
gadomski Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,16 @@ jobs:
GIT_COMMITTER_EMAIL: ci-bot@example.com
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # for git describe
- uses: Swatinem/rust-cache@v2
- uses: astral-sh/setup-uv@v3
with:
enable-cache: true
- name: Install Python
run: uv python install # we use uv instead of setup-python so we get python-version resolution between our two packages
- name: Sync
run: uv sync
run: uv sync && uv sync --no-dev --inexact --directory python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just reading about uv workspaces and in the future it would be cool to explore if that could work here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They've got an issue for syncing workspaces: astral-sh/uv#5727

It'd be swell if it did work, because I really like this pattern generally (have a shared lockfile, split up deps into the package where you need 'em).

- name: Deploy
run: |
VERSION=$(git describe --tags --match="v*" --abbrev=0)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
branches:
- main
tags:
- '*'
- 'v*'
paths:
- python/**
pull_request:
Expand Down
3 changes: 1 addition & 2 deletions RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,4 @@ Then:
4. Update each README
5. Open a PR
6. Once approved, merge the PR
7. (if releasing the main crate) Run `cargo release -p cql2`, then `cargo release -p cql2 --execute`
8. (if releasing the cli crate) run `cargo release -p cql2-cli`, then `cargo release -p cql2-cli --execute`
7. `cargo release -p cql2 --execute`, then `cargo release -p cql2-cli --execute`
Loading