Fix docs deploy #40
Merged
Fix docs deploy #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Oct 10, 2024
| - uses: Swatinem/rust-cache@v2 | ||
| - uses: astral-sh/setup-uv@v3 | ||
| with: | ||
| enable-cache: true | ||
| - name: Install Python | ||
| run: uv python install # we use uv instead of setup-python so we get python-version resolution between our two packages | ||
| - name: Sync | ||
| run: uv sync | ||
| run: uv sync && uv sync --no-dev --inexact --directory python |
There was a problem hiding this comment.
I was just reading about uv workspaces and in the future it would be cool to explore if that could work here.
There was a problem hiding this comment.
They've got an issue for syncing workspaces: astral-sh/uv#5727
It'd be swell if it did work, because I really like this pattern generally (have a shared lockfile, split up deps into the package where you need 'em).
kylebarron
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not surprisingly (to me at least) I did it wrong on the first pass: https://github.com/developmentseed/cql2-rs/actions/runs/11280618987/job/31373989523. Couple other nit-y cleanups along the way.
EDIT: confirmed fix on manual run