-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future / proposed spec changes #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this makes sense in these spots. 👍
For parallel scripts though, this also means that the json_reference needs a tweak since type for the "Lifecycle scripts" commands in the is now string, array, or object. There's a description of string vs array there, so I think we'd need to summarize parallel execution there too.
Like in the other case, probably makes sense to add this to the respective spots in devcontainers/spec so we don't have a snafu on copying across later. 😄
Few other comments below!
Thanks for the review @Chuxel! I've done the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts (which would also apply to devcontainers/spec#128)
Co-authored-by: Chuck Lantz <clantz@microsoft.com>
Thanks so much for the great review and collab @Chuxel. I'll merge this PR and devcontainers/spec#128 after the next Dev Containers release next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one comment on the additional devcontainer.json properties.
As the release is out, merging now. Thanks! |
Updating based on devcontainers/cli#228 and devcontainers/spec#89.
As discussed, I believe we want to wait to merge these changes for another few weeks, but I wanted to open the PR for discussion now.