Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future / proposed spec changes #56

Merged
merged 13 commits into from
Nov 2, 2022
Merged

Conversation

bamurtaugh
Copy link
Member

Updating based on devcontainers/cli#228 and devcontainers/spec#89.

As discussed, I believe we want to wait to merge these changes for another few weeks, but I wanted to open the PR for discussion now.

@bamurtaugh bamurtaugh requested a review from Chuxel October 21, 2022 18:14
@bamurtaugh bamurtaugh requested a review from a team as a code owner October 21, 2022 18:14
@bamurtaugh bamurtaugh self-assigned this Oct 21, 2022
Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this makes sense in these spots. 👍

For parallel scripts though, this also means that the json_reference needs a tweak since type for the "Lifecycle scripts" commands in the is now string, array, or object. There's a description of string vs array there, so I think we'd need to summarize parallel execution there too.

Like in the other case, probably makes sense to add this to the respective spots in devcontainers/spec so we don't have a snafu on copying across later. 😄

Few other comments below!

@bamurtaugh
Copy link
Member Author

Thanks for the review @Chuxel! I've done the following:

@bamurtaugh bamurtaugh requested a review from Chuxel October 24, 2022 22:07
Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts (which would also apply to devcontainers/spec#128)

@bamurtaugh
Copy link
Member Author

Thanks so much for the great review and collab @Chuxel. I'll merge this PR and devcontainers/spec#128 after the next Dev Containers release next week.

Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment on the additional devcontainer.json properties.

@bamurtaugh
Copy link
Member Author

As the release is out, merging now. Thanks!

@bamurtaugh bamurtaugh merged commit 1f19036 into gh-pages Nov 2, 2022
@bamurtaugh bamurtaugh deleted the bamurtaugh/other-spec branch November 2, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants