This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
Change spark server initialization to service #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tobisaninfo could you please post this issue in github.com/ferwasy/spark-test? |
|
Here is the issue, that inspires me for this pull request |
|
@Tobisaninfo the issue is now ferwasy#1 and the PR should be submitted there (and not in this repository here). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use spark-test in multiple unit test classes, the initialization of the spark server have to be changed by using the Service class provided by spark.
Problem by this implementation is the need of adjusting the route registration, as seen in the test classes.
I tested the changes with your test classes and in a different project, having three test classes.