Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

SparkServer After(), add Spark.awaitStop(); ? #14

Open
namack75 opened this issue Dec 18, 2018 · 9 comments
Open

SparkServer After(), add Spark.awaitStop(); ? #14

namack75 opened this issue Dec 18, 2018 · 9 comments

Comments

@namack75
Copy link

Ran into an issue when i had different tests (with different Application definitions), as the 2nd test spooled up, the Spark server wasn't fully cleaned up.

@imbananko
Copy link

@namack75, hi. same issue. any workarounds?

@ghost
Copy link

ghost commented Mar 3, 2019

Don't know if its the same, but I can't seem to be able to test multiple controllers, at least according to the one and only given example...

@ferwasy
Copy link
Contributor

ferwasy commented Mar 19, 2019

Ran into an issue when i had different tests (with different Application definitions), as the 2nd test spooled up, the Spark server wasn't fully cleaned up.

Can you provide some example source code?

@ferwasy
Copy link
Contributor

ferwasy commented Mar 19, 2019

Don't know if its the same, but I can't seem to be able to test multiple controllers, at least according to the one and only given example...

Can you provide some example source code?

@victornoel
Copy link

I confirm there is a problem, SparkServer.after() should be calling Spark.awaitStop().

@ferwasy anyway to get Spark.awaitStop() added to the after() method to ensure the Spark server is properly stopped (because stop() executes in a Thread).

@ferwasy
Copy link
Contributor

ferwasy commented Oct 23, 2019

I confirm there is a problem, SparkServer.after() should be calling Spark.awaitStop().

@ferwasy anyway to get Spark.awaitStop() added to the after() method to ensure the Spark server is properly stopped (because stop() executes in a Thread).

Hi @victornoel. I will continue the maintainance of the project in this fork https://github.com/ferwasy/spark-test. Could you post the issue there?
Thank you very much!

@victornoel
Copy link

@ferwasy great news. I can't create issue in the fork, I think maybe you need to enable them for the project or something like that?

@ferwasy
Copy link
Contributor

ferwasy commented Nov 4, 2019

@victornoel could you try it now?

@victornoel
Copy link

@ferwasy Done, thanks: ferwasy#1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants