feat: CosmWasm 1.0.0-beta implementation #720

leobragaz · 2022-01-11T11:37:50Z

Description

Closes: #115.

This PR integrate the CosmWasm module into Desmos.
At the current stage, no rules are applied to the smart contracts store/instantiate flow and any kind of contract can
be deployed on the network if we will update the testnet as it is.
I think that for testing purposes this is the best choice, however, I will work on an ADR for permissioned contracts and contracts limitations soon. Since Desmos is a social network related project, contracts deployment should be limited to contracts that are social-related.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…on testnet when wasm got updated to cosmos v0.44

…ed the compilation errors

…wasm-1.0.0-beta � Conflicts: � go.mod � go.sum

- added a missing wasmvm dependency

wasm keeper and perform some checks against end blocker events

Cleaned the wasm-1.0.0-beta from the experimental implementations of contracts logic and moved that logic in another branch

…wasm-1.0.0-beta � Conflicts: � app/app.go � go.sum � x/staging/fees/ante/common_test.go

…n it - updated ibc to fix wasm implementation errors - removed wasm parameters from app constructor - updated wasmd with the cosmos v0.44.5 official branch

…wasm-1.0.0-beta � Conflicts: � app/ante.go � app/app.go � go.mod � go.sum

finished integrating cosmwasm module in the desmos app

fixed tests errors added missing go.sum file

codecov · 2022-01-11T14:10:59Z

Codecov Report

Merging #720 (2b3c635) into master (23cb923) will decrease coverage by 0.04%.
The diff coverage is 78.94%.

❗ Current head 2b3c635 differs from pull request most recent head 1cbf7f9. Consider uploading reports for the commit 1cbf7f9 to get more accurate results

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   78.81%   78.77%   -0.05%     
==========================================
  Files          53       53              
  Lines        4320     4387      +67     
==========================================
+ Hits         3405     3456      +51     
- Misses        737      749      +12     
- Partials      178      182       +4

Impacted Files	Coverage Δ
app/app.go	`80.61% <78.37%> (-0.88%)`	⬇️
app/ante.go	`65.71% <100.00%> (+2.07%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23cb923...1cbf7f9. Read the comment docs.

in Dockerfile

…brary

added missing build_tags lines in Makefile

reverted unwanted changes

leobragaz · 2022-01-12T11:44:52Z

Build errors on ARM and ARM-64 fails due to an incompatibility of one of the wasmVM depedencies, wasmer.
Further info here:
CosmWasm/wasmvm#53

.changeset/entries/2a0f58483ba1a78a98c387a7b1f77456761346794551aa9e2a2cb5b287b82bd6.yaml

CHANGELOG.md

RiccardoM · 2022-01-13T10:21:10Z

Makefile

+build_tags += $(BUILD_TAGS)
+build_tags := $(strip $(build_tags))



Why is this necessary?

To make the muslc library for static linking of libraries (which is needed for the wasmvm one) available during the build. Without it, the build will fail.

@bragaz Can we then add a comment to the Makefile just to remember why those are there in the future please?

app/app.go

CHANGELOG.md

removed arm, arm64 builds from github test action

it can lead to 0 and break the tests

Makefile

RiccardoM · 2022-01-17T11:43:58Z

Great job! 💯 As soon as @dadamu accepts it as well it should be auto merged

dadamu

Ready to go

leobragaz added 17 commits October 29, 2021 15:31

added wasmd dependencies and prepared a branch to be deployable soon …

67067ae

…on testnet when wasm got updated to cosmos v0.44

updated go.mod/sum

bbb34c4

updated wasmd dependency with cyber fork that supports v0.44 plus fix…

cfe6db0

…ed the compilation errors

Merge branch 'master' of github.com:desmos-labs/desmos into leonardo/…

c6eaf35

…wasm-1.0.0-beta � Conflicts: � go.mod � go.sum

added custom wasm msgs parsers

58b9439

renamed cosmwasm folder and parsers names

f65f46f

added message handler in app go, plus profiles save/delete routing

d7b72d9

added wasm query parser for profiles module

fdc24a5

- fixing some lint errors

ede65e7

- added a missing wasmvm dependency

added more desmos messages inside the parser

c6f6bfc

updated profiles keeper with a decorator to enables

88c8d7f

wasm keeper and perform some checks against end blocker events

removed wasm keeper from the profiles keeper

6af5766

Cleaned the wasm-1.0.0-beta from the experimental implementations of contracts logic and moved that logic in another branch

Merge branch 'master' of github.com:desmos-labs/desmos into leonardo/…

7bdc12d

…wasm-1.0.0-beta � Conflicts: � app/app.go � go.sum � x/staging/fees/ante/common_test.go

updated gosum

e814d8b

- added ante handler in order to integrate some cosmwasm decorators i…

eb45b1e

…n it - updated ibc to fix wasm implementation errors - removed wasm parameters from app constructor - updated wasmd with the cosmos v0.44.5 official branch

Merge branch 'master' of github.com:desmos-labs/desmos into leonardo/…

7a45b91

…wasm-1.0.0-beta � Conflicts: � app/ante.go � app/app.go � go.mod � go.sum

pulled the master with the latest IBCv2 updates

35af679

finished integrating cosmwasm module in the desmos app

github-actions bot added the x/profiles Module that allows to create and manage decentralized social profiles label Jan 11, 2022

added changeset

0a9be75

leobragaz mentioned this pull request Jan 11, 2022

ComsWasm integration #351

Closed

7 tasks

leobragaz changed the title ~~CosmWasm 1.0.0-beta implementation~~ feat: CosmWasm 1.0.0-beta implementation Jan 11, 2022

added changeset

99e0187

fixed tests errors added missing go.sum file

added precompiled library reference for wasmvm

fe96132

in Dockerfile

github-actions bot added the kind/build Related to the build of the project label Jan 12, 2022

leobragaz added 4 commits January 12, 2022 10:54

fixed build command in order to force it to use precompiled wasmvm li…

ff496b9

…brary

added missing packages to docker linux build

5207dc8

added missing build_tags lines in Makefile

added CHANGELOG.md entry

da200d2

removed unused files

36dafee

reverted unwanted changes

github-actions bot removed the x/profiles Module that allows to create and manage decentralized social profiles label Jan 12, 2022

reverted unwanted changes

019f3ca

leobragaz marked this pull request as ready for review January 12, 2022 14:11

leobragaz requested review from RiccardoM and dadamu January 12, 2022 14:11

RiccardoM reviewed Jan 13, 2022

View reviewed changes

leobragaz added 2 commits January 14, 2022 15:22

fixed reviews requests

9d960aa

reverted makefile changes

21c8288

leobragaz requested a review from RiccardoM January 14, 2022 14:52

RiccardoM reviewed Jan 17, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

fixed RandomizedGenState in profiles module

edefdb9

github-actions bot added the x/profiles Module that allows to create and manage decentralized social profiles label Jan 17, 2022

removed blank line inside CHANGELOG.md

cd5d984

leobragaz requested a review from RiccardoM January 17, 2022 10:09

added comment line to makefile

8f14963

removed arm, arm64 builds from github test action

github-actions bot added the kind/ci Improve the CI/CD label Jan 17, 2022

removed random intn for profileNumber generation since

735cd45

it can lead to 0 and break the tests

RiccardoM reviewed Jan 17, 2022

View reviewed changes

Makefile Outdated Show resolved Hide resolved

RiccardoM approved these changes Jan 17, 2022

View reviewed changes

Update Makefile

2b3c635

RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jan 17, 2022

dadamu approved these changes Jan 18, 2022

View reviewed changes

Merge branch 'master' into leonardo/wasm-1.0.0-beta

1cbf7f9

mergify bot merged commit 76c0eaf into master Jan 18, 2022

mergify bot deleted the leonardo/wasm-1.0.0-beta branch January 18, 2022 04:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: CosmWasm 1.0.0-beta implementation #720

feat: CosmWasm 1.0.0-beta implementation #720

leobragaz commented Jan 11, 2022 •

edited

Loading

codecov bot commented Jan 11, 2022 •

edited

Loading

leobragaz commented Jan 12, 2022

RiccardoM Jan 13, 2022

leobragaz Jan 14, 2022

RiccardoM Jan 17, 2022

RiccardoM commented Jan 17, 2022

dadamu left a comment

		build_tags += $(BUILD_TAGS)
		build_tags := $(strip $(build_tags))

feat: CosmWasm 1.0.0-beta implementation #720

feat: CosmWasm 1.0.0-beta implementation #720

Conversation

leobragaz commented Jan 11, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

codecov bot commented Jan 11, 2022 • edited Loading

Codecov Report

leobragaz commented Jan 12, 2022

RiccardoM Jan 13, 2022

Choose a reason for hiding this comment

leobragaz Jan 14, 2022

Choose a reason for hiding this comment

RiccardoM Jan 17, 2022

Choose a reason for hiding this comment

RiccardoM commented Jan 17, 2022

dadamu left a comment

Choose a reason for hiding this comment

leobragaz commented Jan 11, 2022 •

edited

Loading

codecov bot commented Jan 11, 2022 •

edited

Loading